Code review comment for ~ahasenack/ubuntu/+source/cyrus-sasl2:groovy-sasl-disable-doc-build

Revision history for this message
Bryce Harrington (bryce) wrote :

This looks great. I verified the build locally and installed the cyrus-sasl2-doc_2.1.27+dfsg-2ubuntu1_all.deb binary package, and randomly lynx-navigated around stuff in /usr/share/doc/cyrus-sasl2-doc. I could find no broken links or problematic behaviors.

Given how minimal the packaging fix was, and that it fixes an easily discerned user-facing bug, I do think this is worth inclusion. Indeed, these user docs are going to be more broadly applicable to users than the sphinx-generated code docs. Since this is documentation there would not be the level of worry if it was a code change for introducing a regrssion. The only thought I have is that it might worth having a bug report LP# associated but I don't think that's a huge deal.

So LGTM, +1.

review: Approve

« Back to merge proposal