Ubuntu
curl package

Code review comment for ~ahasenack/ubuntu/+source/curl:mantic-curl-slapd-dep8-test

  1. Git
  2. lp:~ahasenack/ubuntu/+source/curl
  3. mantic-curl-slapd-dep8-test
  4. Merge into ubuntu/devel
Revision history for this message
Bryce Harrington (bryce) wrote :

Looks good, the addition of the retry logic with sleep(1) makes sense. The cleanup() logic for printing out extra debug info is a good practice that I bet would be good to spread to other dep8 tests.

Anyway, LGTM, +1.

review: Approve

« Back to merge proposal