Code review comment for ~ahasenack/ubuntu/+source/bind9:eoan-re-enable-eddsa-support

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

I pushed a new update that will fail the build if we are not using openssl 1.1.1 or higher. That being said, both disco and eoan no longer have libssl-dev 1.1.0, so with default distro packages from the archive this check is a noop, and is an extra delta.

Let me know what you think. We can:
a) go back to having the simple delta of just dropping --with-eddsa=no, no further changes
b) keep this last version I pushed, which drops the --with-eddsa=no line, but also drops the "(optional)" flag from the symbols file, making it a mandatory symbol.

« Back to merge proposal