Code review comment for ~ahasenack/ubuntu/+source/base-files:xenial-handle-was-removed-1895302

Revision history for this message
Bryce Harrington (bryce) wrote :

44d97359a4f73cad77e9bf30b0c1bd21b4d4c732
  - Seems a reasonable solution.
  - I'm curious if you tried dpkg -s ubuntu-server and found that the -l option with grep was better?

989427c706c868917534627390bca6b28baeeb55
  - LGTM. Much cleaner looking and likely more maintainable.

29622498abfe7ed935eacc9abefd476505e4e34c
  - Do I understand correctly that this differentiates between installs vs. upgrades by $2 being non-blank? If so, is it 100% guaranteed that this is always blank on install?

52a955f23051e297070e594d78e89436b3a1c893
  - LGTM

6ca97cfce91cc40d8fbf6c5a61f487c5c2659f43
  - Changelog looks good.

A couple questions just to clarify some assumptions. Otherwise, looks good.

If you'd like me to run the test cases before you land this, I can do that tomorrow.

review: Approve

« Back to merge proposal