Code review comment for ~ahasenack/ubuntu/+source/base-files:groovy-motd-news-config-split

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

Ok, Steve came back and said:
<vorlon> ahasenack: hi, managing to reply before you drop off IRC for the day; I think the corner case in question is acceptable to not address, but needs to be called out in the SRU
<vorlon> (as "regression potential")

I then mentioned the attempt above at fixing this corner case, and he analyzed the changes, and said:
<vorlon> ahasenack: yeah, so I'm vaguely inclined to leave this corner case unfixed but called out in the SRU, rather than add additional complicated maintscript handling; but I wouldn't block the SRU if you do add the maintscript stuff

I fear that this complicated handling in maintainerscripts might introduce more bugs. Let's try without it, and call out the corner case you found in the bug?

« Back to merge proposal