Ubuntu
base-files package

Code review comment for ~ahasenack/ubuntu/+source/base-files:bionic-motd-news-per-cloud

  1. Git
  2. lp:~ahasenack/ubuntu/+source/base-files
  3. bionic-motd-news-per-cloud
  4. Merge into ubuntu/bionic-devel
Revision history for this message
Bryce Harrington (bryce) wrote :

Completed review of the motd changes, including running the test cases in a bionic lxd container. One suggested technical change for numerical comparisons (ok by me to fix with the upload), but otherwise rest LGTM. Tests worked as expected on bionic.

  - [√] changelog entry correct, targeted to correct codename
  - [√] version number correct
  - [√] update-maintainer has been run
  - [~] patches match what was proposed upstream
  - [~] patches correctly included in debian/patches/series?
  - [~] patches have correct DEP3 metadata
  - [~] autopkgtest passes
  - [√] test case a: confirm Kata Containers motd
        sudo sh /etc/update-motd.d/50-motd-news --force
  - [√] test case b: confirm cloud_id set in user-agent to "cloud_id/lxd"
 sudo sh -x /etc/update-motd.d/50-motd-news --force 2>&1| grep -E "curl .*cloud_id/"
  - [√] test case c: list timers to confirm motd-news is active
        ... 10h left Tue 2019-10-01 17:15:33 UTC 1h 20min ago motd-news.timer motd-news.service

review: Approve

« Back to merge proposal