Code review comment for ~ahasenack/ubuntu/+source/backuppc:xenial-backuppc-smb-1576187

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Nice data digging to get to the log :-)
+1 on adding the test along the fix.
This would also make it catch other simmilar issues further on with the tool relying on output "a lot"

Minor optional changes inline, but +1 on the MP as is if you want to keep it that way.

review: Approve

« Back to merge proposal