>
> > + if ! testparm -s 2>&1 | grep -qE "^\[${share}\]"; then
> > + echo "Adding [${share}] share"
> > + cat >> /etc/samba/smb.conf <<EOFEOF
> > +[${share}]
>
> Indentation isn't important, it's just aesthetic. What do you mean by
> inline, just a bunch of echo's instead of cat? Or both [${share}] and the
> lines below it in column 1?
>
All moved from column 1 to the column of "cat"+4
But this is style/opinion-only, so only follow if you prefer that as well.
Keep it as-is otherwise please
>
> > + if ! testparm -s 2>&1 | grep -qE "^\[${share}\]"; then
> > + echo "Adding [${share}] share"
> > + cat >> /etc/samba/smb.conf <<EOFEOF
> > +[${share}]
>
> Indentation isn't important, it's just aesthetic. What do you mean by
> inline, just a bunch of echo's instead of cat? Or both [${share}] and the
> lines below it in column 1?
>
All moved from column 1 to the column of "cat"+4
But this is style/opinion-only, so only follow if you prefer that as well.
Keep it as-is otherwise please