Code review comment for ~ahasenack/ubuntu/+source/autofs:cosmic-merge-5.1.2-3

Yes, when -Bsymbolic-functions is used, the global config variable "disappears" in autofs modules. The ensuing crash is a null pointer deref. What the lookup-ldap patch does is initialize it again inside the module. And it's only needed in that particular module because -Bsymbolic-functions, despite being stripped from LDFLAGS, leaks into the command line via the krb5 libraries, which come from a call to "krb5-config --libs".

I bet this is also the source of the segfaults I was seeing when autofs linked with tirpc. The segfault was happening inside such a module, and I couldn't figure out why certain variables were suddenly NULL pointers.

I'm not sure what to do here. -Bsymbolic-functions seems something foundations decided upon 10 years ago (and debian hasn't adopted yet). Stripping it from krb5-config --libs seems a bit too hardcore. I'm not sure what's the intention of this flag anyway: why is it something good to have? Knowing that would be needed before submitting the lookup-ldap patch upstream.