Code review comment for ~ahasenack/ubuntu/+source/autofs:cosmic-merge-5.1.2-3

On Thu, Jun 7, 2018 at 4:40 AM,  Christian Ehrhardt  <email address hidden> wrote:

    I wonder on the two older kept changes, both about 3 years old:
    + - Add LDFLAGS to avoid issues with accessing global variables in
    + shared libraries (LP #1470687, LP #1472115).
    + - d/p/fix-lookup-ldap-crash.patch: fix crash on startup due to uninitialized
    + config.
    There should be either of the following:
    a) dropping the code, build it and retest the old bugs - still triggers -> submit to Debian as well
    b) dropping the code, build it and retest the old bugs - no more triggers -> Drop Delta

    On the crash I'd assume it still appears and needs to be reported.

I'll check the ldap case.

    On the LDFLAGS instead I doubt this still really works.
    First our build log [1] still has symbolic-functions while Debian [2] has not.
    So the fix might be incomplete these days or is it no more important?

dpkg-buildflags in Ubuntu outputs the symbolic-functions setting, but Debian's does not. If the build happens with that linker flag set, automount segfaults on startup on a null pointer deref. The global variable holding the config suddenly becomes a NULL as autofs plugins are loaded. So there is no need to push this one to Debian.

    Anyway I'd appreciate if you would look into those two Deltas.

    Also you mentioned segfaults when building that on Ubuntu - was that riddle solved as well?

It was a one-line incorrect merge on my part that didn't remove the symbolic-functions flag, and that causes a crash on startup as explained above.