© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
73416ba
(Get the code!)
Hi,
tags LGTM
dropped changes: ack
retained changes: correctly retained
So this is all good, but has some optional things we might want to look into on this merge.
I wonder on the two older kept changes, both about 3 years old:
+ - Add LDFLAGS to avoid issues with accessing global variables in
+ shared libraries (LP #1470687, LP #1472115).
+ - d/p/fix-
+ config.
There should be either of the following:
a) dropping the code, build it and retest the old bugs - still triggers -> submit to Debian as well
b) dropping the code, build it and retest the old bugs - no more triggers -> Drop Delta
On the crash I'd assume it still appears and needs to be reported.
On the LDFLAGS instead I doubt this still really works.
First our build log [1] still has symbolic-functions while Debian [2] has not.
So the fix might be incomplete these days or is it no more important?
Anyway I'd appreciate if you would look into those two Deltas.
Also you mentioned segfaults when building that on Ubuntu - was that riddle solved as well?
Finally I have two super-minor changelog nit picks that you can consider (or not) depending on your mood.
[1]: https:/
[2]: https:/