Merge ~ahasenack/ubuntu/+source/apr-util:eoan-dbd-mysql-module-load into ubuntu/+source/apr-util:ubuntu/devel

Proposed by Andreas Hasenack
Status: Superseded
Proposed branch: ~ahasenack/ubuntu/+source/apr-util:eoan-dbd-mysql-module-load
Merge into: ubuntu/+source/apr-util:ubuntu/devel
Diff against target: 66 lines (+36/-0) (has conflicts)
3 files modified
debian/changelog (+9/-0)
debian/patches/mysql8-my_init.patch (+23/-0)
debian/patches/series (+4/-0)
Conflict in debian/changelog
Conflict in debian/patches/series
Reviewer Review Type Date Requested Status
Canonical Server Core Reviewers Pending
Canonical Server Pending
Review via email: mp+380247@code.launchpad.net

This proposal has been superseded by a proposal from 2020-03-04.

Description of the change

Fix loading the mysql dbd module.

Testing instructions are in the linked bug.

I pinged Lars in #ubuntu-devel and he agreed my_init() shouldn't be needed at all.

PPA for testing: https://launchpad.net/~ahasenack/+archive/ubuntu/mysql8-my-init/

Note that eoan's mysql8 still export my_bool.

To post a comment you must log in.

Unmerged commits

312ea47... by Andreas Hasenack

update-metadata

08ee360... by Andreas Hasenack

changelog

3801058... by Andreas Hasenack

  * d/p/mysql8-my_init.patch: don't call my_init() since it's not
    exported anymore since MySQL 8.0.2 (LP: #1859773)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/debian/changelog b/debian/changelog
index 75eba76..137ec01 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,4 @@
1<<<<<<< debian/changelog
1apr-util (1.6.1-4ubuntu1) focal; urgency=medium2apr-util (1.6.1-4ubuntu1) focal; urgency=medium
23
3 * Adjust Build-Depends to unambiguously require Python 2.4 * Adjust Build-Depends to unambiguously require Python 2.
@@ -5,6 +6,14 @@ apr-util (1.6.1-4ubuntu1) focal; urgency=medium
5 (LP: #1863026)6 (LP: #1863026)
67
7 -- Robie Basak <robie.basak@ubuntu.com> Tue, 18 Feb 2020 14:53:49 +00008 -- Robie Basak <robie.basak@ubuntu.com> Tue, 18 Feb 2020 14:53:49 +0000
9=======
10apr-util (1.6.1-4ubuntu0.1) eoan; urgency=medium
11
12 * d/p/mysql8-my_init.patch: don't call my_init() since it's not
13 exported anymore since MySQL 8.0.2 (LP: #1859773)
14
15 -- Andreas Hasenack <andreas@canonical.com> Wed, 04 Mar 2020 17:00:31 -0300
16>>>>>>> debian/changelog
817
9apr-util (1.6.1-4build1) eoan; urgency=medium18apr-util (1.6.1-4build1) eoan; urgency=medium
1019
diff --git a/debian/patches/mysql8-my_init.patch b/debian/patches/mysql8-my_init.patch
11new file mode 10064420new file mode 100644
index 0000000..3be2139
--- /dev/null
+++ b/debian/patches/mysql8-my_init.patch
@@ -0,0 +1,23 @@
1Description: don't call my_init()
2 Since MySQL 8.0.2, my_init() isn't exported anymore and shouldn't have to be
3 called by clients directly. See
4 https://dev.mysql.com/doc/relnotes/mysql/8.0/en/news-8-0-2.html
5Author: Andreas Hasenack <andreas@canonical.com>
6Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/apache2/+bug/1859773
7Forwarded: no
8X-Forwarded-Reason: Should have an explicit check for MySQL 8.0.2
9Last-Update: 2020-03-04
10---
11This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
12--- a/dbd/apr_dbd_mysql.c
13+++ b/dbd/apr_dbd_mysql.c
14@@ -1263,9 +1263,6 @@
15
16 static void dbd_mysql_init(apr_pool_t *pool)
17 {
18-#if MYSQL_VERSION_ID < 100000
19- my_init();
20-#endif
21 mysql_thread_init();
22
23 /* FIXME: this is a guess; find out what it really does */
diff --git a/debian/patches/series b/debian/patches/series
index 3e71f6a..aafb7a0 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -11,4 +11,8 @@ fix_doxygen_inputdir
11support_mariadb.patch11support_mariadb.patch
12doxygen_no_ful_path_names.patch12doxygen_no_ful_path_names.patch
13fix_gdbm_error_handling13fix_gdbm_error_handling
14<<<<<<< debian/patches/series
14mysql8_my_bool.patch15mysql8_my_bool.patch
16=======
17mysql8-my_init.patch
18>>>>>>> debian/patches/series

Subscribers

People subscribed via source and target branches