Code review comment for ~ahasenack/ubuntu/+source/apache2:focal-apache2-last-merge

Revision history for this message
Bryce Harrington (bryce) wrote :

* Changelog:
  - [√] changelog entry correct version and targeted codename
  - [√] changelog entries correct
  - [√] update-maintainer has been run

* Actual changes:
  - [-] no upstream changes to consider
  - [√] no further upstream version to consider
  - [√] debian changes look safe

* Old Delta:
  - [-] dropped changes are ok to be dropped
  - [√] nothing else to drop
  - [√] changes forwarded upstream/debian (if appropriate)

* New Delta:
  - [√] no new patches added
  - [-] patches match what was proposed upstream
  - [-] patches correctly included in debian/patches/series
  - [-] patches have correct DEP3 metadata

* Build/Test:
  - [ ] build is ok
  - [ ] verified PPA package installs/uninstalls
  - [ ] autopkgtest against the PPA package passes
  - [ ] sanity checks test fine

Just need to verify the testing, the rest LGTM.

I'm kind of curious if these two items could be landed to Debian, but assume if they could they would have already:
    - debian/patches/086_svn_cross_compiles: Backport several cross
      fixes from upstream
    - d/t/control, d/t/check-http2: add basic test for http2 support

review: Needs Information

« Back to merge proposal