Ubuntu
apache2 package

Code review comment for ~ahasenack/ubuntu/+source/apache2:disco-apache2-2.4.37-merge

  1. Git
  2. lp:~ahasenack/ubuntu/+source/apache2
  3. disco-apache2-2.4.37-merge
  4. Merge into debian/sid
Revision history for this message
Robie Basak (racb) wrote :

range-diff mismatches 3 and 4 are context only. 7 is correctly dropped (verified in Ubuntu and Debian's CVE tracker). All delta therefore transferred correctly.

Changes in Debian and upstream don't look like they'll affect our delta.

update-maintainer and changelog entries look good.

I'll leave with you, doesn't affect review outcome: does the http2 dep8 test want sending upstream? Or is that already done, or not appropriate?

Needs Information: Is the 3c4eef8 delta ("don't build libapache2-mod-md") still required? libapache2-mod-shib2 -> libapache2-mod-shib -> libxmltooling8 -> libcurl4 now. Rather than libcurl3 as described at https://bugs.launchpad.net/ubuntu/+source/apache2/+bug/1770242/comments/1. So is there still a conflict with libcurl3 or is that situation gone?

All other delta looks appropriate to keep.

review: Needs Information

« Back to merge proposal