Merge ~ahasenack/ubuntu-seeds/+git/platform:disco-remove-authbind-supported into ~ubuntu-core-dev/ubuntu-seeds/+git/platform:disco

Proposed by Andreas Hasenack
Status: Merged
Approved by: Christian Ehrhardt 
Approved revision: 964d273432e7b46dec875926b398db2658f2231e
Merged at revision: 964d273432e7b46dec875926b398db2658f2231e
Proposed branch: ~ahasenack/ubuntu-seeds/+git/platform:disco-remove-authbind-supported
Merge into: ~ubuntu-core-dev/ubuntu-seeds/+git/platform:disco
Diff against target: 13 lines (+1/-1)
1 file modified
supported-sysadmin-common (+1/-1)
Reviewer Review Type Date Requested Status
Christian Ehrhardt  Approve
Andreas Hasenack Abstain
Canonical Server Pending
Canonical Server Core Reviewers Pending
Review via email: mp+363071@code.launchpad.net

Description of the change

Update the reason why we are keeping authbind in the supported seed.

Originally added in 2005:
https://git.launchpad.net/~ubuntu-core-dev/ubuntu-seeds/+git/ubuntu/commit/?id=a8d5ac595

Ubuntu devel thread:
https://lists.ubuntu.com/archives/ubuntu-devel/2019-February/040591.html

To post a comment you must log in.
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

There are hints that #is needs this still, dropping the MP.

review: Disapprove
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

A seed change mentioning that then as a comment maybe?

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

Sounds good

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

Force pushed

Revision history for this message
Andreas Hasenack (ahasenack) :
review: Abstain
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

I followed the discussion, yeah I think that will be helpful on any later re-reviews of the seeds.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/supported-sysadmin-common b/supported-sysadmin-common
2index 18a8000..1970ea8 100644
3--- a/supported-sysadmin-common
4+++ b/supported-sysadmin-common
5@@ -20,7 +20,7 @@
6 * autofs
7 * awstats
8 * acct
9- * authbind
10+ * authbind # still in use in launchpad, https://lists.ubuntu.com/archives/ubuntu-devel/2019-February/040591.html
11 * siege
12 * bonnie++
13 * sqlite3 # CLI utility, libs in main. nijaba

Subscribers

People subscribed via source and target branches