Landscape Charm

Code review comment for lp:~ahasenack/landscape-charm/service-names-1379133

  1. service-names-1379133
  2. Merge into trunk
Revision history for this message
Chad Smith (chad.smith) wrote :

[1] & [2] inline comments that are nits. I'd like to avoid truncating unacceptable characters in var names if we can replace them with underscores instead. Maybe the hyphens in service names were there for readability.

[3] Also can you run "make lint" target and sort the lint errors in this branch.

« Back to merge proposal