Code review comment for lp:~agrimm/bzr-fastimport/baseline-commit

Revision history for this message
Jelmer Vernooij (jelmer) wrote :

Hi Andy,

Thanks again for working on this.

Generally, we try to put commands that modify fastexport streams into "bzr fast-import-filter", rather than "bzr fast-export". In this case, I guess it also skips

+ help="Export an 'abolute' baseline commit prior to"
This should probably say "absolute".

+ assert(len(revobj.parent_ids))
+ previd = revobj.parent_ids[0]
It seems a bit odd that the code uses the parent of the revision that was specified, rather than that revision itself.

Can you add some tests for this new behaviour?

Cheers,

Jelmer

« Back to merge proposal