Merge lp:~agilebg/sale-wkfl/adding_account_fiscal_position_country_sale_7 into lp:~sale-core-editors/sale-wkfl/7.0

[Alex Comba - Agile BG]

This branch adds the account_fiscal_position_country_sale porting to 7.0

The module extends the account_fiscal_position_country_sale to sale orders.

[Lorenzo Battistini (elbati)]

account_fiscal_position_country_sale/sale_view.xml: is it still needed?

line 114: too long

review: Needs Fixing

[lp:~agilebg/sale-wkfl/adding_account_fiscal_position_country_sale_7]

22. By Alex Comba - Agile BG on 2013-08-28

[REM] unnecessary sale_view.xml

[Alex Comba - Agile BG (tafaru)]

Lorenzo, you were right: sale_view.xml is unnecessary, thanks!

[Lorenzo Battistini (elbati)]

review: Approve

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

Same remark than https://code.launchpad.net/~agilebg/account-invoicing/adding_account_fiscal_position_country_7/+merge/182636/comments/415438

review: Needs Information

[Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c)]

+1 for having an explanation on this comment "Seems redundant with account_fiscal_position_rule in the https://code.launchpad.net/openerp-fiscal-rules project.
Do you have a reason for not reusing it?"

review: Needs Information

[Lorenzo Battistini (elbati)]

This MP can be rejected for the same reason as
https://code.launchpad.net/~agilebg/account-invoicing/adding_account_fiscal_position_country_7/+merge/182636
Thanks!

review: Disapprove

Unmerged revisions

22. By Alex Comba - Agile BG on 2013-08-28

[REM] unnecessary sale_view.xml

21. By Alex Comba - Agile BG on 2013-08-28

[FIX] method onchange_partner_id_fiscal_position

20. By Alex Comba - Agile BG on 2013-08-27

[REF] ported module account_fiscal_position_country_sale to ver. 7.0

19. By Alex Comba - Agile BG on 2013-08-27

[ADD] module account_fiscal_position_country_sale ver. 6.1

=== added directory 'account_fiscal_position_country_sale'
=== added file 'account_fiscal_position_country_sale/__init__.py'
--- account_fiscal_position_country_sale/__init__.py	1970-01-01 00:00:00 +0000
+++ account_fiscal_position_country_sale/__init__.py	2013-08-28 16:22:51 +0000
@@ -0,0 +1,23 @@
+# -*- coding: utf-8 -*-
+##############################################################################
+#
+#    Copyright (C) 2011 Domsense srl (<http://www.domsense.com>)
+#    Copyright (C) 2011-2013 Agile Business Group sagl 
+#	 (<http://www.agilebg.com>)
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as published
+#    by the Free Software Foundation, either version 3 of the License, or
+#    (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+
+import sale
 
=== added file 'account_fiscal_position_country_sale/__openerp__.py'
--- account_fiscal_position_country_sale/__openerp__.py	1970-01-01 00:00:00 +0000
+++ account_fiscal_position_country_sale/__openerp__.py	2013-08-28 16:22:51 +0000
@@ -0,0 +1,44 @@
+# -*- coding: utf-8 -*-
+##############################################################################
+#
+#    Copyright (C) 2011 Domsense srl (<http://www.domsense.com>)
+#    Copyright (C) 2011-2013 Agile Business Group sagl
+#    (<http://www.agilebg.com>)
+#    @author Leonardo Pistone <[e-mail]>
+#    Ported to OpenERP 7.0 by Alex Comba <[e-mail]>
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as published
+#    by the Free Software Foundation, either version 3 of the License, or
+#    (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+
+{
+    'name': 'Fiscal Position by country, sales',
+    'version': '0.3',
+    'category': 'Generic Modules/Accounting',
+    'description': """
+A rule to select automatically the fiscal position in a sale order
+This module extends the account_fiscal_position_country_sale to sale orders.
+The modules are kept separate to reduce dependencies
+    """,
+    'author': 'Agile Business Group',
+    'website': 'http://www.agilebg.com',
+    'license': 'AGPL-3',
+    'depends': [
+        'account_fiscal_position_country',
+        'sale'
+    ],
+    'data': [],
+    'active': False,
+    'installable': True,
+}
 
=== added file 'account_fiscal_position_country_sale/sale.py'
--- account_fiscal_position_country_sale/sale.py	1970-01-01 00:00:00 +0000
+++ account_fiscal_position_country_sale/sale.py	2013-08-28 16:22:51 +0000
@@ -0,0 +1,43 @@
+# -*- coding: utf-8 -*-
+##############################################################################
+#
+#    Copyright (C) 2011 Domsense srl (<http://www.domsense.com>)
+#    Copyright (C) 2011-2013 Agile Business Group sagl 
+#    (<http://www.agilebg.com>)
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as published
+#    by the Free Software Foundation, either version 3 of the License, or
+#    (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+
+from openerp.osv import fields, orm
+
+
+class sale_order(orm.Model):
+    _inherit = "sale.order"
+
+    def onchange_partner_id(self, cr, uid, ids, partner_id, context=None):
+        result = super(sale_order, self).onchange_partner_id(
+            cr, uid, ids, partner_id, context=context)
+        if not result['value']['fiscal_position']:
+        	if partner_id:
+	        	partner = self.pool.get('res.partner').browse(
+                    cr, uid, partner_id)
+	        	result['value']['fiscal_position'] = (
+                    partner.country_id 
+                    and partner.country_id.property_account_position 
+                    and partner.country_id.property_account_position.id 
+                    or False
+                )
+
+        return result