Merge lp:~agilebg/purchase-wkfl/7.0-bug-1312024-tafaru into lp:~purchase-core-editors/purchase-wkfl/7.0
Status: | Merged |
---|---|
Approved by: | Yannick Vaucher @ Camptocamp on 2014-05-14 |
Approved revision: | 34 |
Merged at revision: | 33 |
Proposed branch: | lp:~agilebg/purchase-wkfl/7.0-bug-1312024-tafaru |
Merge into: | lp:~purchase-core-editors/purchase-wkfl/7.0 |
Diff against target: |
83 lines (+27/-16) 2 files modified
product_by_supplier/__openerp__.py (+18/-10) product_by_supplier/product.py (+9/-6) |
To merge this branch: | bzr merge lp:~agilebg/purchase-wkfl/7.0-bug-1312024-tafaru |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Lorenzo Battistini (community) | code review | Approve on 2014-05-07 | |
Pedro Manuel Baeza | code review | 2014-04-24 | Approve on 2014-05-06 |
Alexandre Fayolle - camptocamp | code review, no test | Approve on 2014-05-06 | |
Review via email:
|
Commit message
[FIX] bug #1312024
Description of the change
This branch contains the fix for https:/
Alex Comba - Agile BG (tafaru) wrote : | # |
Lorenzo,
following are listed the reasons:
'images': this key doesn't compare in https:/
'sequence': using https:/
Pedro Manuel Baeza (pedro.baeza) wrote : | # |
Hi, Alex, some remarks:
- Contributors are put on 'contributors' key in manifest file as a list, not in description.
- I prefer to add purchase as dependency that changes the place where the menu is displayed, because this query is not useful if you don't use purchase module.
Regards.
- 34. By Alex Comba - Agile BG on 2014-04-28
-
[FIX] bug #1312024: revert commit 32 and added purchase to depends
Alex Comba - Agile BG (tafaru) wrote : | # |
Hi Pedro,
thank you for your review, my comments are in line.
> Contributors are put on 'contributors' key in manifest file as a list, not in description.
As far as I can see here https:/
> I prefer to add purchase as dependency
Done in my last commit.
Cheers.
LGTM
Pedro Manuel Baeza (pedro.baeza) wrote : | # |
Hi, Alex,
Thanks for the changes. Indeed, in contributors section of the documentation, there's still a reference to add it at the end of the description. Initial intention was to get a dedicated section under the key 'contributors' of the manifest file to be displayed on module list, but this is something still not possible, so that way is for now the valid one.
Regards.
Thanks Alex,
why did you remove the 'images' and 'sequence' items?