Code review comment for lp:~agilebg/purchase-wkfl/7.0-bug-1312024-tafaru

Alex Comba - Agile BG (tafaru) wrote :

Lorenzo,

following are listed the reasons:

'images': this key doesn't compare in https://doc.openerp.com/trunk/server/03_module_dev_01/#manifest-file-openerp-py: also comparing https://www.openerp.com/apps/7.0/product_by_supplier/ and https://www.openerp.com/apps/7.0/product_supplier_info/ I noticed the image in the first one has broken link. So I gathered was a good solution to remove it;
'sequence': using https://github.com/nbessi/openerp-conventions I get ' O600 Warning unknown Manifest key ('sequence')' so I thought to remove it.

« Back to merge proposal