Merge lp:~agilebg/openobject-italia/imp_save_fiscalcode_data into lp:~nicolariolini/openobject-italia/save_fiscalcode_data

Proposed by Lorenzo Battistini
Status: Merged
Merged at revision: 233
Proposed branch: lp:~agilebg/openobject-italia/imp_save_fiscalcode_data
Merge into: lp:~nicolariolini/openobject-italia/save_fiscalcode_data
Diff against target: 129 lines (+41/-32)
2 files modified
l10n_it_fiscalcode/fiscalcode.py (+0/-4)
l10n_it_fiscalcode/wizard/compute_fc.py (+41/-28)
To merge this branch: bzr merge lp:~agilebg/openobject-italia/imp_save_fiscalcode_data
Reviewer Review Type Date Requested Status
Nicola Riolini - Micronaet Pending
Review via email: mp+194477@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Nicola Riolini - Micronaet (nicolariolini) wrote :

Direi che ha migliorato aspetto :)
Ok per me

Revision history for this message
Lorenzo Battistini (elbati) wrote :

On 11/08/2013 11:14 AM, Nicola Riolini - Micronaet wrote:
> Direi che ha migliorato aspetto :)
> Ok per me

Puoi mergiarlo nel tuo branch con

bzr merge lp:~agilebg/openobject-italia/imp_save_fiscalcode_data

Revision history for this message
Nicola Riolini - Micronaet (nicolariolini) wrote :

grazie, ho visto il suggerimento di Launchapad, spero di non avere fatto casini :)

Revision history for this message
Lorenzo Battistini (elbati) wrote :

On 11/08/2013 11:21 AM, Nicola Riolini - Micronaet wrote:
> grazie, ho visto il suggerimento di Launchapad, spero di non avere fatto casini :)

Non ne hai fatti :-)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'l10n_it_fiscalcode/fiscalcode.py'
--- l10n_it_fiscalcode/fiscalcode.py 2013-11-08 09:43:06 +0000
+++ l10n_it_fiscalcode/fiscalcode.py 2013-11-08 10:03:22 +0000
@@ -20,10 +20,6 @@
20##############################################################################20##############################################################################
2121
22from osv import fields, osv22from osv import fields, osv
23import tools
24import pooler
25from tools.translate import _
26import datetime
2723
2824
29class res_partner(osv.osv):25class res_partner(osv.osv):
3026
=== modified file 'l10n_it_fiscalcode/wizard/compute_fc.py'
--- l10n_it_fiscalcode/wizard/compute_fc.py 2013-11-08 09:43:06 +0000
+++ l10n_it_fiscalcode/wizard/compute_fc.py 2013-11-08 10:03:22 +0000
@@ -20,8 +20,6 @@
20##############################################################################20##############################################################################
2121
22from osv import fields, osv22from osv import fields, osv
23import tools
24import pooler
25from tools.translate import _23from tools.translate import _
26import datetime24import datetime
2725
@@ -44,17 +42,26 @@
4442
45 _defaults = {43 _defaults = {
46 # Leggo da res.partner i dati se presenti per impostarli come default:44 # Leggo da res.partner i dati se presenti per impostarli come default:
47 'fiscalcode_surname': lambda s, cr, uid, c: s.get_default_from_partner(45 'fiscalcode_surname': (
48 cr, uid, 'fiscalcode_surname', context=c),46 lambda s, cr, uid, c: s.get_default_from_partner(
49 'fiscalcode_firstname': lambda s, cr, uid, c:47 cr, uid, 'fiscalcode_surname', context=c)
50 s.get_default_from_partner(cr, uid,48 ),
51 'fiscalcode_firstname', context=c),49 'fiscalcode_firstname': (
52 'birth_date': lambda s, cr, uid, c: s.get_default_from_partner(cr, uid,50 lambda s, cr, uid, c: s.get_default_from_partner(
53 'birth_date', context=c),51 cr, uid, 'fiscalcode_firstname', context=c)
54 'birth_city': lambda s, cr, uid, c: s.get_default_from_partner(cr, uid,52 ),
55 'birth_city', context=c),53 'birth_date': (
56 'sex': lambda s, cr, uid, c: s.get_default_from_partner(cr, uid, 'sex',54 lambda s, cr, uid, c: s.get_default_from_partner(
57 context=c),55 cr, uid, 'birth_date', context=c)
56 ),
57 'birth_city': (
58 lambda s, cr, uid, c: s.get_default_from_partner(
59 cr, uid, 'birth_city', context=c)
60 ),
61 'sex': (
62 lambda s, cr, uid, c: s.get_default_from_partner(
63 cr, uid, 'sex', context=c)
64 ),
58 }65 }
5966
60 def get_default_from_partner(self, cr, uid, field, context=None):67 def get_default_from_partner(self, cr, uid, field, context=None):
@@ -69,7 +76,7 @@
69 if not partner_id:76 if not partner_id:
70 return False77 return False
71 partner_proxy = self.pool.get('res.partner').browse(78 partner_proxy = self.pool.get('res.partner').browse(
72 cr, uid, partner_id, context=context)79 cr, uid, partner_id, context=context)
73 res = partner_proxy.__getattr__(field)80 res = partner_proxy.__getattr__(field)
7481
75 if field == 'birth_city': # many2one82 if field == 'birth_city': # many2one
@@ -158,10 +165,12 @@
158 context)165 context)
159 form_obj = self.browse(cr, uid, ids, context)166 form_obj = self.browse(cr, uid, ids, context)
160 for fields in form_obj:167 for fields in form_obj:
161 if (not fields.fiscalcode_surname or168 if (
169 not fields.fiscalcode_surname or
162 not fields.fiscalcode_firstname or170 not fields.fiscalcode_firstname or
163 not fields.birth_date or171 not fields.birth_date or
164 not fields.birth_city or not fields.sex):172 not fields.birth_city or not fields.sex
173 ):
165 raise osv.except_osv(_('Error'),174 raise osv.except_osv(_('Error'),
166 _('One or more fields are missing'))175 _('One or more fields are missing'))
167 if not fields.birth_city.cadaster_code:176 if not fields.birth_city.cadaster_code:
@@ -169,9 +178,10 @@
169 _('Cataster code is missing'))178 _('Cataster code is missing'))
170 birth_date = datetime.datetime.strptime(fields.birth_date,179 birth_date = datetime.datetime.strptime(fields.birth_date,
171 "%Y-%m-%d")180 "%Y-%m-%d")
172 CF = self._codicefiscale(fields.fiscalcode_surname,181 CF = self._codicefiscale(
173 fields.fiscalcode_firstname,182 fields.fiscalcode_surname,
174 str(birth_date.day),183 fields.fiscalcode_firstname,
184 str(birth_date.day),
175 str(birth_date.month), str(birth_date.year), fields.sex,185 str(birth_date.month), str(birth_date.year), fields.sex,
176 fields.birth_city.cadaster_code)186 fields.birth_city.cadaster_code)
177 if partner.fiscalcode and partner.fiscalcode != CF:187 if partner.fiscalcode and partner.fiscalcode != CF:
@@ -181,13 +191,16 @@
181 one (%s). If you want to use the computed one, remove191 one (%s). If you want to use the computed one, remove
182 the existing one') % (partner.fiscalcode, CF"""))192 the existing one') % (partner.fiscalcode, CF"""))
183 self.pool.get('res.partner').write(193 self.pool.get('res.partner').write(
184 cr, uid, active_id,194 cr, uid, active_id,
185 {'fiscalcode': CF,195 {'fiscalcode': CF,
186 'individual': True,196 'individual': True,
187 # Storicizzo in res.partner i dati usati dal wizard197 # Storicizzo in res.partner i dati usati dal wizard
188 'fiscalcode_surname': fields.fiscalcode_surname,198 'fiscalcode_surname': fields.fiscalcode_surname,
189 'fiscalcode_firstname': fields.fiscalcode_firstname,199 'fiscalcode_firstname': fields.fiscalcode_firstname,
190 'birth_date': fields.birth_date,200 'birth_date': fields.birth_date,
191 'birth_city': fields.birth_city.id if fields.birth_city else False,201 'birth_city': (
192 'sex': fields.sex, })202 fields.birth_city.id if fields.birth_city
203 else False
204 ),
205 'sex': fields.sex, })
193 return {}206 return {}

Subscribers

People subscribed via source and target branches