Merge lp:~agilebg/openobject-addons/7.0-bug-1111430-elbati into lp:openobject-addons/7.0

Proposed by Lorenzo Battistini
Status: Needs review
Proposed branch: lp:~agilebg/openobject-addons/7.0-bug-1111430-elbati
Merge into: lp:openobject-addons/7.0
Diff against target: 86 lines (+30/-16)
3 files modified
account/account_invoice.py (+0/-14)
purchase/purchase.py (+15/-1)
sale/sale.py (+15/-1)
To merge this branch: bzr merge lp:~agilebg/openobject-addons/7.0-bug-1111430-elbati
Reviewer Review Type Date Requested Status
OpenERP Core Team Pending
Review via email: mp+176179@code.launchpad.net
To post a comment you must log in.

Unmerged revisions

9306. By Lorenzo Battistini

[FIX] account.invoice.line fields_view_get is broken

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'account/account_invoice.py'
--- account/account_invoice.py 2013-06-12 15:38:14 +0000
+++ account/account_invoice.py 2013-07-22 12:21:17 +0000
@@ -1441,20 +1441,6 @@
1441 'account_id': _default_account_id,1441 'account_id': _default_account_id,
1442 }1442 }
14431443
1444 def fields_view_get(self, cr, uid, view_id=None, view_type='form', context=None, toolbar=False, submenu=False):
1445 if context is None:
1446 context = {}
1447 res = super(account_invoice_line,self).fields_view_get(cr, uid, view_id=view_id, view_type=view_type, context=context, toolbar=toolbar, submenu=submenu)
1448 if context.get('type', False):
1449 doc = etree.XML(res['arch'])
1450 for node in doc.xpath("//field[@name='product_id']"):
1451 if context['type'] in ('in_invoice', 'in_refund'):
1452 node.set('domain', "[('purchase_ok', '=', True)]")
1453 else:
1454 node.set('domain', "[('sale_ok', '=', True)]")
1455 res['arch'] = etree.tostring(doc)
1456 return res
1457
1458 def product_id_change(self, cr, uid, ids, product, uom_id, qty=0, name='', type='out_invoice', partner_id=False, fposition_id=False, price_unit=False, currency_id=False, context=None, company_id=None):1444 def product_id_change(self, cr, uid, ids, product, uom_id, qty=0, name='', type='out_invoice', partner_id=False, fposition_id=False, price_unit=False, currency_id=False, context=None, company_id=None):
1459 if context is None:1445 if context is None:
1460 context = {}1446 context = {}
14611447
=== modified file 'purchase/purchase.py'
--- purchase/purchase.py 2013-07-10 21:56:55 +0000
+++ purchase/purchase.py 2013-07-22 12:21:17 +0000
@@ -20,6 +20,7 @@
20##############################################################################20##############################################################################
2121
22import time22import time
23from lxml import etree
23import pytz24import pytz
24from openerp import SUPERUSER_ID25from openerp import SUPERUSER_ID
25from datetime import datetime26from datetime import datetime
@@ -1224,4 +1225,17 @@
1224 wf_service.trg_validate(uid, 'purchase.order', context['default_res_id'], 'send_rfq', cr)1225 wf_service.trg_validate(uid, 'purchase.order', context['default_res_id'], 'send_rfq', cr)
1225 return super(mail_compose_message, self).send_mail(cr, uid, ids, context=context)1226 return super(mail_compose_message, self).send_mail(cr, uid, ids, context=context)
12261227
1227# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:1228class account_invoice_line(osv.Model):
1229 _inherit = 'account.invoice.line'
1230
1231 def fields_view_get(self, cr, uid, view_id=None, view_type='form', context=None, toolbar=False, submenu=False):
1232 if context is None:
1233 context = {}
1234 res = super(account_invoice_line,self).fields_view_get(cr, uid, view_id=view_id, view_type=view_type, context=context, toolbar=toolbar, submenu=submenu)
1235 if context.get('type', False):
1236 doc = etree.XML(res['arch'])
1237 for node in doc.xpath("//field[@name='product_id']"):
1238 if context['type'] in ('in_invoice', 'in_refund'):
1239 node.set('domain', "[('purchase_ok', '=', True)]")
1240 res['arch'] = etree.tostring(doc)
1241 return res
12281242
=== modified file 'sale/sale.py'
--- sale/sale.py 2013-06-07 11:38:29 +0000
+++ sale/sale.py 2013-07-22 12:21:17 +0000
@@ -19,6 +19,7 @@
19#19#
20##############################################################################20##############################################################################
2121
22from lxml import etree
22from datetime import datetime, timedelta23from datetime import datetime, timedelta
23from dateutil.relativedelta import relativedelta24from dateutil.relativedelta import relativedelta
24import time25import time
@@ -1011,4 +1012,17 @@
1011 wf_service.trg_validate(uid, 'account.invoice', id, 'invoice_cancel', cr)1012 wf_service.trg_validate(uid, 'account.invoice', id, 'invoice_cancel', cr)
1012 return super(account_invoice, self).unlink(cr, uid, ids, context=context)1013 return super(account_invoice, self).unlink(cr, uid, ids, context=context)
10131014
1014# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:1015class account_invoice_line(osv.Model):
1016 _inherit = 'account.invoice.line'
1017
1018 def fields_view_get(self, cr, uid, view_id=None, view_type='form', context=None, toolbar=False, submenu=False):
1019 if context is None:
1020 context = {}
1021 res = super(account_invoice_line,self).fields_view_get(cr, uid, view_id=view_id, view_type=view_type, context=context, toolbar=toolbar, submenu=submenu)
1022 if context.get('type', False):
1023 doc = etree.XML(res['arch'])
1024 for node in doc.xpath("//field[@name='product_id']"):
1025 if context['type'] in ('out_invoice', 'out_refund'):
1026 node.set('domain', "[('sale_ok', '=', True)]")
1027 res['arch'] = etree.tostring(doc)
1028 return res