Code review comment for lp:~agilebg/openerp-product-attributes/adding_product_pack_7

Leonardo Pistone (lepistone) wrote :

Thank you Lorenzo, Alex.

- Translations, if they are old and/or incorrect, IMO we can remove them for now. You could leave whatever works for you (i.e. Italian) and remove everything else

- Defaults: lambda is not needed anymore

- I see some long, multi-line comments in the code. Maybe some could be moved in some more prominent place, like docstrings?


review: Needs Fixing (code review, no test)

« Back to merge proposal