Code review comment for lp:~agilebg/openerp-product-attributes/adding_product_pack_7
Revision history for this message
| Leonardo Pistone (lepistone) wrote | # |
review:
Needs Fixing
(code review, no test)
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
73416ba
(Get the code!)
Thank you Lorenzo, Alex.
- Translations, if they are old and/or incorrect, IMO we can remove them for now. You could leave whatever works for you (i.e. Italian) and remove everything else
- Defaults: lambda is not needed anymore
- I see some long, multi-line comments in the code. Maybe some could be moved in some more prominent place, like docstrings?
L