Code review comment for lp:~agilebg/account-invoicing/adding_stock_invoice_picking_incoterm_7

Revision history for this message
Alex Comba - Agile BG (tafaru) wrote :

Hi, Pedro, thanks a lot for your review.

I made the changes as you suggested, please have a look at them.

About:
> Don't you think that it's convenient to copy incoterm (if any) from sale order to picking?

This module depends on 'stock_invoice_picking' and has been designed on purpose when 'sale' e 'sale_stock are not used. Be the case, for what you suggested, we could make something additional like 'stock_invoice_picking_incoterm_sale'.

Cheers.

« Back to merge proposal