Merge lp:~agilebg/account-invoicing/7.0-bug-1287179-hurrinico into lp:~account-core-editors/account-invoicing/7.0

Proposed by Nicola Malcontenti - Agile BG
Status: Merged
Approved by: Yannick Vaucher @ Camptocamp
Approved revision: 40
Merged at revision: 41
Proposed branch: lp:~agilebg/account-invoicing/7.0-bug-1287179-hurrinico
Merge into: lp:~account-core-editors/account-invoicing/7.0
Diff against target: 67 lines (+40/-3)
3 files modified
account_invoice_shipping_address/__init__.py (+1/-0)
account_invoice_shipping_address/__openerp__.py (+3/-3)
account_invoice_shipping_address/stock.py (+36/-0)
To merge this branch: bzr merge lp:~agilebg/account-invoicing/7.0-bug-1287179-hurrinico
Reviewer Review Type Date Requested Status
Holger Brunn (Therp) code review Approve
Alexandre Fayolle - camptocamp code review, no test Approve
Lorenzo Battistini (community) code review Approve
Andrea Cometa Pending
Review via email: mp+209207@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Lorenzo Battistini (elbati) wrote :

Whithin the _prepare_invoice method I see tabs and spaces mixed

review: Needs Fixing
39. By Hurrinico

[FIX] pep8 fix

Revision history for this message
Nicola Malcontenti - Agile BG (hurrin1c0) wrote :

> Whithin the _prepare_invoice method I see tabs and spaces mixed
done

Revision history for this message
Lorenzo Battistini (elbati) :
review: Approve (code review)
Revision history for this message
Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c) wrote :

LGTM.

review: Approve (code review, no test)
40. By Lorenzo Battistini

[IMP] description

Revision history for this message
Holger Brunn (Therp) (hbrunn) :
review: Approve (code review)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'account_invoice_shipping_address/__init__.py'
--- account_invoice_shipping_address/__init__.py 2013-09-04 13:41:03 +0000
+++ account_invoice_shipping_address/__init__.py 2014-03-06 13:53:22 +0000
@@ -22,3 +22,4 @@
2222
23import invoice23import invoice
24import sale24import sale
25import stock
2526
=== modified file 'account_invoice_shipping_address/__openerp__.py'
--- account_invoice_shipping_address/__openerp__.py 2013-09-11 14:01:17 +0000
+++ account_invoice_shipping_address/__openerp__.py 2014-03-06 13:53:22 +0000
@@ -25,10 +25,10 @@
25 "name": "Invoice Shipping Address",25 "name": "Invoice Shipping Address",
26 "version": "0.1",26 "version": "0.1",
27 'category': 'Generic Modules/Accounting',27 'category': 'Generic Modules/Accounting',
28 "depends": ["account", "sale"],28 "depends": ["account", "sale", "sale_stock"],
29 "author": "Andrea Cometa, Agile Business Group",29 "author": "Andrea Cometa, Agile Business Group",
30 "description": """Adds a shipping address field to the invoice, also fill30 "description": """This module adds a shipping address field to the invoice, also it fills
31it in sale invoicing""",31it in sale and picking invoicing""",
32 'website': 'http://www.andreacometa.it',32 'website': 'http://www.andreacometa.it',
33 'data': [33 'data': [
34 'invoice_view.xml',34 'invoice_view.xml',
3535
=== added file 'account_invoice_shipping_address/stock.py'
--- account_invoice_shipping_address/stock.py 1970-01-01 00:00:00 +0000
+++ account_invoice_shipping_address/stock.py 2014-03-06 13:53:22 +0000
@@ -0,0 +1,36 @@
1# -*- coding: utf-8 -*-
2##############################################################################
3#
4# Copyright (C) 2014 Agile Business Group sagl (<http://www.agilebg.com>)
5# Author: Nicola Malcontenti <nicola.malcontenti@agilebg.com>
6#
7# This program is free software: you can redistribute it and/or modify
8# it under the terms of the GNU Affero General Public License as published
9# by the Free Software Foundation, either version 3 of the License, or
10# (at your option) any later version.
11#
12# This program is distributed in the hope that it will be useful,
13# but WITHOUT ANY WARRANTY; without even the implied warranty of
14# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15# GNU Affero General Public License for more details.
16#
17# You should have received a copy of the GNU Affero General Public License
18# along with this program. If not, see <http://www.gnu.org/licenses/>.
19#
20##############################################################################
21
22from openerp.osv import fields, orm
23from openerp.tools.translate import _
24
25
26class stock_picking(orm.Model):
27 _inherit = "stock.picking"
28
29 def _prepare_invoice(
30 self, cr, uid, picking, partner,
31 inv_type, journal_id, context=None):
32 invoice_vals = super(stock_picking, self)._prepare_invoice(
33 cr, uid, picking, partner, inv_type, journal_id, context=context)
34 if picking and picking.partner_id:
35 invoice_vals['address_shipping_id'] = picking.partner_id.id
36 return invoice_vals

Subscribers

People subscribed via source and target branches