Code review comment for lp:~agilebg/account-invoice-report/adding_account_invoice_production_lot_7
Revision history for this message
| Raphaël Valyi - http://www.akretion.com (rvalyi) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
f33e652
(Get the code!)
Hello,
just a word, to say that I fully agree with all Alexis comments: 1) to 4).
I don't remember where it was, but I believe there was a previous merge proposal (that has probably been dropped in favor of this one), where I believe Pedro Baeza was commenting the same that trying to avoid report_webkit would be ideal (that is split the module in two). Just like Alexis, I agree about prod_lot_ids becoming a regular m2m ideally unless mandatory this way.
If you do all that, we are probably going to get our Brazilian localization depends on that new module as for us mentioning product serial in the electronic invoice is mandatory and we hack it our own way currently.
Regards.