Merge lp:~agateau/ubiquity/kde-fix-going-back into lp:ubiquity

Proposed by Aurélien Gâteau
Status: Merged
Merged at revision: 6040
Proposed branch: lp:~agateau/ubiquity/kde-fix-going-back
Merge into: lp:ubiquity
Diff against target: 22 lines (+4/-1)
1 file modified
ubiquity/frontend/kde_ui.py (+4/-1)
To merge this branch: bzr merge lp:~agateau/ubiquity/kde-fix-going-back
Reviewer Review Type Date Requested Status
Dimitri John Ledkov Approve
Jonathan Riddell Pending
Review via email: mp+191806@code.launchpad.net

Description of the change

Fix going back so that it can go through disabled steps.

To post a comment you must log in.
Revision history for this message
Dimitri John Ledkov (xnox) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'ubiquity/frontend/kde_ui.py'
2--- ubiquity/frontend/kde_ui.py 2013-09-27 12:47:58 +0000
3+++ ubiquity/frontend/kde_ui.py 2013-10-18 13:04:48 +0000
4@@ -426,7 +426,6 @@
5 if self.current_page is None:
6 break
7
8- self.backup = False
9 page = self.pages[self.pagesindex]
10 skip = False
11 if hasattr(page.ui, 'plugin_skip_page'):
12@@ -876,6 +875,10 @@
13
14 def set_page(self, n):
15 self.run_automation_error_cmd()
16+ # We only stop the backup process when we're on a page where questions
17+ # need to be asked, otherwise you wont be able to back up past
18+ # pages that do not stop on questions or are preseeded away.
19+ self.backup = False
20 self.ui.show()
21
22 #set all the steps active

Subscribers

People subscribed via source and target branches

to status/vote changes: