Merge lp:~agateau/lightdm/move-to-sbin into lp:lightdm
Status: | Rejected |
---|---|
Rejected by: | Robert Ancell |
Proposed branch: | lp:~agateau/lightdm/move-to-sbin |
Merge into: | lp:lightdm |
Diff against target: |
61 lines (+5/-5) 5 files modified
data/Makefile.am (+1/-1) data/guest-session.apparmor (+1/-1) src/Makefile.am (+1/-1) src/display.c (+1/-1) utils/Makefile.am (+1/-1) |
To merge this branch: | bzr merge lp:~agateau/lightdm/move-to-sbin |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Robert Ancell | Needs Fixing | ||
Review via email: mp+89146@code.launchpad.net |
Description of the change
Install lightdm-
This makes it easier to call lightdm-
Moving lightdm-
The alternative would be to force libexecdir to /usr/lib on the packaging side, I can provide a MR for the packaging branch if you prefer to keep lightdm code as is.
Unmerged revisions
- 1363. By Aurélien Gâteau
-
Install lightdm-
set-defaults and lightdm- guest-session- wrapper in $prefix/sbin This makes it easier to call lightdm-
set-defaults from admin scripts because
one does not have to worry about its path. It is especially important when
multiarch packaging is involved because in this case $(libexecdir) or
$(pkglibexecdir) are architecture-dependents, making it difficult to call any
binary there from another package.Moving lightdm-
guest-session- wrapper to $prefix/sbin is also useful to avoid
putting it in $PATH for all users. It was in $PATH previously because it is in
the same dir as gdmflexiserver.
The lightdm- set-defaults change is fine, not sure what packages need updating to use the new location though. Perhaps a symlink is needed in the packaging for migration?
I'm unsure about the other changes as I'm not 100% what they do and haven't have the time to review.