Merge lp:~agateau/kubuntu-debug-installer/ui-fixes into lp:kubuntu-debug-installer

Proposed by Aurélien Gâteau
Status: Merged
Merged at revision: not available
Proposed branch: lp:~agateau/kubuntu-debug-installer/ui-fixes
Merge into: lp:kubuntu-debug-installer
Diff against target: 25 lines (+6/-2)
1 file modified
src/dbginstaller.cpp (+6/-2)
To merge this branch: bzr merge lp:~agateau/kubuntu-debug-installer/ui-fixes
Reviewer Review Type Date Requested Status
Harald Sitter Approve
Review via email: mp+21027@code.launchpad.net

Description of the change

Just saw your post about kubuntu-debug-installer and thought the dialog would look a bit better with "Install" and "Cancel" buttons instead of "Yes" and "No".

To post a comment you must log in.
Revision history for this message
Harald Sitter (apachelogger) :
review: Approve
Revision history for this message
Harald Sitter (apachelogger) wrote :

Merged into trunk as r33, I took the liberty to change the continue button to KStandardGuiItem's one.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/dbginstaller.cpp'
--- src/dbginstaller.cpp 2010-03-06 10:34:39 +0000
+++ src/dbginstaller.cpp 2010-03-10 08:27:15 +0000
@@ -71,7 +71,9 @@
71 "Do you want to continue anyway?");71 "Do you want to continue anyway?");
72 QString msgcaption = i18n("Couldn't find debug packages");72 QString msgcaption = i18n("Couldn't find debug packages");
73 int ret = KMessageBox::warningYesNoList(this, msgtext, *m_nodbgpkgs,73 int ret = KMessageBox::warningYesNoList(this, msgtext, *m_nodbgpkgs,
74 msgcaption);74 msgcaption,
75 KGuiItem(i18n("Continue"), "dialog-ok"),
76 KStandardGuiItem::cancel());
75 if (ret != KMessageBox::Yes) {77 if (ret != KMessageBox::Yes) {
76 exit(ERR_NO_SYMBOLS);78 exit(ERR_NO_SYMBOLS);
77 }79 }
@@ -83,7 +85,9 @@
83 " so that the necessary debug symbols become available?");85 " so that the necessary debug symbols become available?");
84 QString msgcaption = i18n("Confirm package installation");86 QString msgcaption = i18n("Confirm package installation");
85 int ret = KMessageBox::questionYesNoList(this, msgtext, *m_dbgpkgs,87 int ret = KMessageBox::questionYesNoList(this, msgtext, *m_dbgpkgs,
86 msgcaption);88 msgcaption,
89 KGuiItem(i18n("Install"), "dialog-ok"),
90 KStandardGuiItem::cancel());
87 if(ret != KMessageBox::Yes) {91 if(ret != KMessageBox::Yes) {
88 exit(ERR_CANCEL);92 exit(ERR_CANCEL);
89 }93 }

Subscribers

People subscribed via source and target branches