Merge lp:~agateau/kubuntu-debug-installer/ui-fixes into lp:kubuntu-debug-installer

Proposed by Aurélien Gâteau
Status: Merged
Merged at revision: not available
Proposed branch: lp:~agateau/kubuntu-debug-installer/ui-fixes
Merge into: lp:kubuntu-debug-installer
Diff against target: 25 lines (+6/-2)
1 file modified
src/dbginstaller.cpp (+6/-2)
To merge this branch: bzr merge lp:~agateau/kubuntu-debug-installer/ui-fixes
Reviewer Review Type Date Requested Status
Harald Sitter Approve
Review via email: mp+21027@code.launchpad.net

Description of the change

Just saw your post about kubuntu-debug-installer and thought the dialog would look a bit better with "Install" and "Cancel" buttons instead of "Yes" and "No".

To post a comment you must log in.
Revision history for this message
Harald Sitter (apachelogger) :
review: Approve
Revision history for this message
Harald Sitter (apachelogger) wrote :

Merged into trunk as r33, I took the liberty to change the continue button to KStandardGuiItem's one.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/dbginstaller.cpp'
2--- src/dbginstaller.cpp 2010-03-06 10:34:39 +0000
3+++ src/dbginstaller.cpp 2010-03-10 08:27:15 +0000
4@@ -71,7 +71,9 @@
5 "Do you want to continue anyway?");
6 QString msgcaption = i18n("Couldn't find debug packages");
7 int ret = KMessageBox::warningYesNoList(this, msgtext, *m_nodbgpkgs,
8- msgcaption);
9+ msgcaption,
10+ KGuiItem(i18n("Continue"), "dialog-ok"),
11+ KStandardGuiItem::cancel());
12 if (ret != KMessageBox::Yes) {
13 exit(ERR_NO_SYMBOLS);
14 }
15@@ -83,7 +85,9 @@
16 " so that the necessary debug symbols become available?");
17 QString msgcaption = i18n("Confirm package installation");
18 int ret = KMessageBox::questionYesNoList(this, msgtext, *m_dbgpkgs,
19- msgcaption);
20+ msgcaption,
21+ KGuiItem(i18n("Install"), "dialog-ok"),
22+ KStandardGuiItem::cancel());
23 if(ret != KMessageBox::Yes) {
24 exit(ERR_CANCEL);
25 }

Subscribers

People subscribed via source and target branches