Merge lp:~agateau/gnome-control-center/refresh-icon-view-patch-for-3.5.5 into lp:~ubuntu-desktop/gnome-control-center/ubuntu
- refresh-icon-view-patch-for-3.5.5
- Merge into ubuntu
Proposed by
Aurélien Gâteau
Status: | Merged |
---|---|
Merged at revision: | 354 |
Proposed branch: | lp:~agateau/gnome-control-center/refresh-icon-view-patch-for-3.5.5 |
Merge into: | lp:~ubuntu-desktop/gnome-control-center/ubuntu |
Diff against target: |
212 lines (+38/-42) 2 files modified
debian/changelog (+7/-0) debian/patches/58_ubuntu_icon_views_redesign.patch (+31/-42) |
To merge this branch: | bzr merge lp:~agateau/gnome-control-center/refresh-icon-view-patch-for-3.5.5 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Sebastien Bacher | Pending | ||
Review via email: mp+93450@code.launchpad.net |
Commit message
Description of the change
Refresh the icon views and category header patch for 3.5.5
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1 | === modified file 'debian/changelog' | |||
2 | --- debian/changelog 2012-02-15 22:17:24 +0000 | |||
3 | +++ debian/changelog 2012-02-16 16:41:17 +0000 | |||
4 | @@ -1,3 +1,10 @@ | |||
5 | 1 | gnome-control-center (1:3.3.5-0ubuntu2) UNRELEASED; urgency=low | ||
6 | 2 | |||
7 | 3 | * debian/patches/58_ubuntu_icon_views_redesign.patch | ||
8 | 4 | - Refresh for 3.5.5 | ||
9 | 5 | |||
10 | 6 | -- Aurélien Gâteau <aurelien.gateau@ubuntu.com> Thu, 16 Feb 2012 17:19:42 +0100 | ||
11 | 7 | |||
12 | 1 | gnome-control-center (1:3.3.5-0ubuntu1) precise; urgency=low | 8 | gnome-control-center (1:3.3.5-0ubuntu1) precise; urgency=low |
13 | 2 | 9 | ||
14 | 3 | * Upload the new serie, that will bring in quite some fixes, we revert | 10 | * Upload the new serie, that will bring in quite some fixes, we revert |
15 | 4 | 11 | ||
16 | === modified file 'debian/patches/58_ubuntu_icon_views_redesign.patch' | |||
17 | --- debian/patches/58_ubuntu_icon_views_redesign.patch 2012-02-12 22:04:11 +0000 | |||
18 | +++ debian/patches/58_ubuntu_icon_views_redesign.patch 2012-02-16 16:41:17 +0000 | |||
19 | @@ -1,8 +1,6 @@ | |||
20 | 1 | === modified file 'shell/cc-shell-category-view.c' | 1 | === modified file 'shell/cc-shell-category-view.c' |
25 | 2 | Index: gnome-control-center-3.3.5/shell/cc-shell-category-view.c | 2 | --- a/shell/cc-shell-category-view.c 2012-02-16 14:27:27 +0000 |
26 | 3 | =================================================================== | 3 | +++ b/shell/cc-shell-category-view.c 2012-02-16 15:10:00 +0000 |
23 | 4 | --- gnome-control-center-3.3.5.orig/shell/cc-shell-category-view.c 2012-02-12 11:13:59.269332303 -0500 | ||
24 | 5 | +++ gnome-control-center-3.3.5/shell/cc-shell-category-view.c 2012-02-12 11:17:26.626360531 -0500 | ||
27 | 6 | @@ -31,12 +31,14 @@ | 4 | @@ -31,12 +31,14 @@ |
28 | 7 | enum | 5 | enum |
29 | 8 | { | 6 | { |
30 | @@ -116,10 +114,10 @@ | |||
31 | 116 | "model", model, NULL); | 114 | "model", model, NULL); |
32 | 117 | } | 115 | } |
33 | 118 | 116 | ||
38 | 119 | Index: gnome-control-center-3.3.5/shell/cc-shell-category-view.h | 117 | |
39 | 120 | =================================================================== | 118 | === modified file 'shell/cc-shell-category-view.h' |
40 | 121 | --- gnome-control-center-3.3.5.orig/shell/cc-shell-category-view.h 2012-02-12 11:13:59.305332481 -0500 | 119 | --- a/shell/cc-shell-category-view.h 2012-02-16 09:44:01 +0000 |
41 | 122 | +++ gnome-control-center-3.3.5/shell/cc-shell-category-view.h 2012-02-12 11:14:01.957345631 -0500 | 120 | +++ b/shell/cc-shell-category-view.h 2012-02-16 12:32:37 +0000 |
42 | 123 | @@ -68,6 +68,7 @@ | 121 | @@ -68,6 +68,7 @@ |
43 | 124 | GType cc_shell_category_view_get_type (void) G_GNUC_CONST; | 122 | GType cc_shell_category_view_get_type (void) G_GNUC_CONST; |
44 | 125 | 123 | ||
45 | @@ -128,10 +126,10 @@ | |||
46 | 128 | GtkTreeModel *model); | 126 | GtkTreeModel *model); |
47 | 129 | CcShellItemView* cc_shell_category_view_get_item_view (CcShellCategoryView *self); | 127 | CcShellItemView* cc_shell_category_view_get_item_view (CcShellCategoryView *self); |
48 | 130 | 128 | ||
53 | 131 | Index: gnome-control-center-3.3.5/shell/cc-shell-model.c | 129 | |
54 | 132 | =================================================================== | 130 | === modified file 'shell/cc-shell-model.c' |
55 | 133 | --- gnome-control-center-3.3.5.orig/shell/cc-shell-model.c 2012-02-12 11:13:59.237332146 -0500 | 131 | --- a/shell/cc-shell-model.c 2012-02-16 14:27:27 +0000 |
56 | 134 | +++ gnome-control-center-3.3.5/shell/cc-shell-model.c 2012-02-12 11:14:01.961345652 -0500 | 132 | +++ b/shell/cc-shell-model.c 2012-02-16 14:49:19 +0000 |
57 | 135 | @@ -43,7 +43,7 @@ | 133 | @@ -43,7 +43,7 @@ |
58 | 136 | theme = gtk_icon_theme_get_default (); | 134 | theme = gtk_icon_theme_get_default (); |
59 | 137 | 135 | ||
60 | @@ -141,10 +139,10 @@ | |||
61 | 141 | if (icon_info) | 139 | if (icon_info) |
62 | 142 | { | 140 | { |
63 | 143 | pixbuf = gtk_icon_info_load_icon (icon_info, &err); | 141 | pixbuf = gtk_icon_info_load_icon (icon_info, &err); |
68 | 144 | Index: gnome-control-center-3.3.5/shell/gnome-control-center.c | 142 | |
69 | 145 | =================================================================== | 143 | === modified file 'shell/gnome-control-center.c' |
70 | 146 | --- gnome-control-center-3.3.5.orig/shell/gnome-control-center.c 2012-02-12 11:13:59.293332423 -0500 | 144 | --- a/shell/gnome-control-center.c 2012-02-16 15:37:06 +0000 |
71 | 147 | +++ gnome-control-center-3.3.5/shell/gnome-control-center.c 2012-02-12 11:14:01.961345652 -0500 | 145 | +++ b/shell/gnome-control-center.c 2012-02-16 16:09:58 +0000 |
72 | 148 | @@ -48,7 +48,8 @@ | 146 | @@ -48,7 +48,8 @@ |
73 | 149 | * for the user than resizing vertically | 147 | * for the user than resizing vertically |
74 | 150 | * Both sizes are defined in https://live.gnome.org/Design/SystemSettings/ */ | 148 | * Both sizes are defined in https://live.gnome.org/Design/SystemSettings/ */ |
75 | @@ -164,17 +162,7 @@ | |||
76 | 164 | }; | 162 | }; |
77 | 165 | 163 | ||
78 | 166 | static const gchar * | 164 | static const gchar * |
90 | 167 | @@ -326,7 +329,8 @@ | 165 | @@ -583,6 +586,8 @@ |
80 | 168 | res = NULL; | ||
81 | 169 | for (l = list; l; l = l->next) | ||
82 | 170 | { | ||
83 | 171 | - res = g_list_append (res, cc_shell_category_view_get_item_view (CC_SHELL_CATEGORY_VIEW (l->data))); | ||
84 | 172 | + if (CC_IS_SHELL_CATEGORY_VIEW (l->data)) | ||
85 | 173 | + res = g_list_append (res, cc_shell_category_view_get_item_view (CC_SHELL_CATEGORY_VIEW (l->data))); | ||
86 | 174 | } | ||
87 | 175 | |||
88 | 176 | g_list_free (list); | ||
89 | 177 | @@ -599,6 +603,8 @@ | ||
91 | 178 | static void | 166 | static void |
92 | 179 | setup_search (GnomeControlCenter *shell) | 167 | setup_search (GnomeControlCenter *shell) |
93 | 180 | { | 168 | { |
94 | @@ -183,7 +171,7 @@ | |||
95 | 183 | GtkWidget *search_scrolled, *search_view, *widget; | 171 | GtkWidget *search_scrolled, *search_view, *widget; |
96 | 184 | GtkCellRenderer *renderer; | 172 | GtkCellRenderer *renderer; |
97 | 185 | GnomeControlCenterPrivate *priv = shell->priv; | 173 | GnomeControlCenterPrivate *priv = shell->priv; |
99 | 186 | @@ -618,7 +624,8 @@ | 174 | @@ -602,7 +607,8 @@ |
100 | 187 | priv->search_view = search_view = cc_shell_item_view_new (); | 175 | priv->search_view = search_view = cc_shell_item_view_new (); |
101 | 188 | gtk_icon_view_set_item_orientation (GTK_ICON_VIEW (search_view), | 176 | gtk_icon_view_set_item_orientation (GTK_ICON_VIEW (search_view), |
102 | 189 | GTK_ORIENTATION_HORIZONTAL); | 177 | GTK_ORIENTATION_HORIZONTAL); |
103 | @@ -193,7 +181,7 @@ | |||
104 | 193 | gtk_icon_view_set_model (GTK_ICON_VIEW (search_view), | 181 | gtk_icon_view_set_model (GTK_ICON_VIEW (search_view), |
105 | 194 | GTK_TREE_MODEL (priv->search_filter)); | 182 | GTK_TREE_MODEL (priv->search_filter)); |
106 | 195 | 183 | ||
108 | 196 | @@ -675,7 +682,8 @@ | 184 | @@ -659,7 +665,8 @@ |
109 | 197 | 185 | ||
110 | 198 | static void | 186 | static void |
111 | 199 | maybe_add_category_view (GnomeControlCenter *shell, | 187 | maybe_add_category_view (GnomeControlCenter *shell, |
112 | @@ -203,7 +191,7 @@ | |||
113 | 203 | { | 191 | { |
114 | 204 | GtkTreeModel *filter; | 192 | GtkTreeModel *filter; |
115 | 205 | GtkWidget *categoryview; | 193 | GtkWidget *categoryview; |
117 | 206 | @@ -683,6 +691,16 @@ | 194 | @@ -667,6 +674,16 @@ |
118 | 207 | if (g_hash_table_lookup (shell->priv->category_views, name) != NULL) | 195 | if (g_hash_table_lookup (shell->priv->category_views, name) != NULL) |
119 | 208 | return; | 196 | return; |
120 | 209 | 197 | ||
121 | @@ -220,7 +208,7 @@ | |||
122 | 220 | /* create new category view for this category */ | 208 | /* create new category view for this category */ |
123 | 221 | filter = gtk_tree_model_filter_new (GTK_TREE_MODEL (shell->priv->store), | 209 | filter = gtk_tree_model_filter_new (GTK_TREE_MODEL (shell->priv->store), |
124 | 222 | NULL); | 210 | NULL); |
126 | 223 | @@ -690,7 +708,7 @@ | 211 | @@ -674,7 +691,7 @@ |
127 | 224 | (GtkTreeModelFilterVisibleFunc) category_filter_func, | 212 | (GtkTreeModelFilterVisibleFunc) category_filter_func, |
128 | 225 | g_strdup (name), g_free); | 213 | g_strdup (name), g_free); |
129 | 226 | 214 | ||
130 | @@ -229,7 +217,7 @@ | |||
131 | 229 | gtk_box_pack_start (GTK_BOX (shell->priv->main_vbox), categoryview, FALSE, TRUE, 0); | 217 | gtk_box_pack_start (GTK_BOX (shell->priv->main_vbox), categoryview, FALSE, TRUE, 0); |
132 | 230 | 218 | ||
133 | 231 | g_signal_connect (cc_shell_category_view_get_item_view (CC_SHELL_CATEGORY_VIEW (categoryview)), | 219 | g_signal_connect (cc_shell_category_view_get_item_view (CC_SHELL_CATEGORY_VIEW (categoryview)), |
135 | 232 | @@ -738,13 +756,15 @@ | 220 | @@ -722,13 +739,15 @@ |
136 | 233 | { | 221 | { |
137 | 234 | GMenuTreeDirectory *subdir; | 222 | GMenuTreeDirectory *subdir; |
138 | 235 | const gchar *dir_name; | 223 | const gchar *dir_name; |
139 | @@ -246,7 +234,7 @@ | |||
140 | 246 | 234 | ||
141 | 247 | /* add the items from this category to the model */ | 235 | /* add the items from this category to the model */ |
142 | 248 | sub_iter = gmenu_tree_directory_iter (subdir); | 236 | sub_iter = gmenu_tree_directory_iter (subdir); |
144 | 249 | @@ -781,7 +801,10 @@ | 237 | @@ -765,7 +784,10 @@ |
145 | 250 | { | 238 | { |
146 | 251 | GnomeControlCenterPrivate *priv = shell->priv; | 239 | GnomeControlCenterPrivate *priv = shell->priv; |
147 | 252 | 240 | ||
148 | @@ -258,7 +246,7 @@ | |||
149 | 258 | gtk_container_set_focus_vadjustment (GTK_CONTAINER (shell->priv->main_vbox), | 246 | gtk_container_set_focus_vadjustment (GTK_CONTAINER (shell->priv->main_vbox), |
150 | 259 | gtk_scrolled_window_get_vadjustment (GTK_SCROLLED_WINDOW (shell->priv->scrolled_window))); | 247 | gtk_scrolled_window_get_vadjustment (GTK_SCROLLED_WINDOW (shell->priv->scrolled_window))); |
151 | 260 | 248 | ||
153 | 261 | @@ -838,7 +861,10 @@ | 249 | @@ -822,7 +844,10 @@ |
154 | 262 | gtk_widget_hide (W (priv->builder, "home-button")); | 250 | gtk_widget_hide (W (priv->builder, "home-button")); |
155 | 263 | gtk_widget_show (W (priv->builder, "search-entry")); | 251 | gtk_widget_show (W (priv->builder, "search-entry")); |
156 | 264 | gtk_widget_hide (W (priv->builder, "lock-button")); | 252 | gtk_widget_hide (W (priv->builder, "lock-button")); |
157 | @@ -270,7 +258,7 @@ | |||
158 | 270 | } | 258 | } |
159 | 271 | else | 259 | else |
160 | 272 | { | 260 | { |
162 | 273 | @@ -1109,6 +1135,23 @@ | 261 | @@ -1093,6 +1118,23 @@ |
163 | 274 | return retval; | 262 | return retval; |
164 | 275 | } | 263 | } |
165 | 276 | 264 | ||
166 | @@ -294,7 +282,7 @@ | |||
167 | 294 | static void | 282 | static void |
168 | 295 | gnome_control_center_init (GnomeControlCenter *self) | 283 | gnome_control_center_init (GnomeControlCenter *self) |
169 | 296 | { | 284 | { |
171 | 297 | @@ -1117,6 +1160,8 @@ | 285 | @@ -1101,6 +1143,8 @@ |
172 | 298 | 286 | ||
173 | 299 | priv = self->priv = CONTROL_CENTER_PRIVATE (self); | 287 | priv = self->priv = CONTROL_CENTER_PRIVATE (self); |
174 | 300 | 288 | ||
175 | @@ -303,7 +291,7 @@ | |||
176 | 303 | /* load the user interface */ | 291 | /* load the user interface */ |
177 | 304 | priv->builder = gtk_builder_new (); | 292 | priv->builder = gtk_builder_new (); |
178 | 305 | 293 | ||
180 | 306 | @@ -1130,6 +1175,8 @@ | 294 | @@ -1114,6 +1158,8 @@ |
181 | 307 | 295 | ||
182 | 308 | /* connect various signals */ | 296 | /* connect various signals */ |
183 | 309 | priv->window = W (priv->builder, "main-window"); | 297 | priv->window = W (priv->builder, "main-window"); |
184 | @@ -312,7 +300,7 @@ | |||
185 | 312 | g_signal_connect_swapped (priv->window, "delete-event", G_CALLBACK (g_object_unref), self); | 300 | g_signal_connect_swapped (priv->window, "delete-event", G_CALLBACK (g_object_unref), self); |
186 | 313 | g_signal_connect (priv->window, "key_press_event", | 301 | g_signal_connect (priv->window, "key_press_event", |
187 | 314 | G_CALLBACK (window_key_press_event), self); | 302 | G_CALLBACK (window_key_press_event), self); |
189 | 315 | @@ -1174,6 +1221,9 @@ | 303 | @@ -1158,6 +1204,9 @@ |
190 | 316 | void | 304 | void |
191 | 317 | gnome_control_center_present (GnomeControlCenter *center) | 305 | gnome_control_center_present (GnomeControlCenter *center) |
192 | 318 | { | 306 | { |
193 | @@ -322,10 +310,10 @@ | |||
194 | 322 | gtk_window_present (GTK_WINDOW (center->priv->window)); | 310 | gtk_window_present (GTK_WINDOW (center->priv->window)); |
195 | 323 | } | 311 | } |
196 | 324 | 312 | ||
201 | 325 | Index: gnome-control-center-3.3.5/shell/shell-search-renderer.c | 313 | |
202 | 326 | =================================================================== | 314 | === modified file 'shell/shell-search-renderer.c' |
203 | 327 | --- gnome-control-center-3.3.5.orig/shell/shell-search-renderer.c 2012-02-12 11:13:59.221332066 -0500 | 315 | --- a/shell/shell-search-renderer.c 2012-02-16 14:27:27 +0000 |
204 | 328 | +++ gnome-control-center-3.3.5/shell/shell-search-renderer.c 2012-02-12 11:14:01.961345652 -0500 | 316 | +++ b/shell/shell-search-renderer.c 2012-02-16 14:49:19 +0000 |
205 | 329 | @@ -215,7 +215,7 @@ | 317 | @@ -215,7 +215,7 @@ |
206 | 330 | 318 | ||
207 | 331 | shell_search_renderer_set_layout (SHELL_SEARCH_RENDERER (cell), widget); | 319 | shell_search_renderer_set_layout (SHELL_SEARCH_RENDERER (cell), widget); |
208 | @@ -360,3 +348,4 @@ | |||
209 | 360 | priv->layout); | 348 | priv->layout); |
210 | 361 | 349 | ||
211 | 362 | cairo_restore (cr); | 350 | cairo_restore (cr); |
212 | 351 |