Code review comment for lp:~agateau/checkbox/keep-tests-ordered2

Revision history for this message
Daniel Manrique (roadmr) wrote :

Hello,

This has been on hold for a while. Ordering in checkbox is a more complex affair than originally thought; everybody wants a different way of sorting, both visually and at run time, and we don't have a clear way of handling all use cases yet.

In any case, the way it's done in this code is, again, by adding the sortkey attribute to jobs which, as explained above, causes other problems. Based on this and the fact that ordering is still somewhat undefined, I'll have to reject this merge request, as it would be impossible to merge it as is. Thanks for your code and we'll keep trying to get ordering working right.

review: Disapprove

« Back to merge proposal