Merge ~afreiberger/juju-lint:add-known-apps into juju-lint:master

Proposed by Drew Freiberger
Status: Merged
Approved by: Andrea Ieri
Approved revision: f369ab1a49ceb264dca19735ea2589bc165f8832
Merged at revision: ee31fa4251e104ba8ff766cb72d61b5aec9c8bae
Proposed branch: ~afreiberger/juju-lint:add-known-apps
Merge into: juju-lint:master
Diff against target: 64 lines (+18/-1)
1 file modified
contrib/canonical-rules.yaml (+18/-1)
Reviewer Review Type Date Requested Status
Andrea Ieri Approve
Review via email: mp+393270@code.launchpad.net

Commit message

Added new charms to juju-lint/contrib rules and updated exception for nrpe/nagios

Description of the change

Updated rules to add new charms and to adjust exception for nagios for nrpe to match https://code.launchpad.net/~arif-ali/juju-lint/+git/juju-lint/+merge/383939 suggestions.

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
Andrea Ieri (aieri) wrote :

lgtm, thanks!

review: Approve
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision ee31fa4251e104ba8ff766cb72d61b5aec9c8bae

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/contrib/canonical-rules.yaml b/contrib/canonical-rules.yaml
2index 8ef2f4d..9555a15 100644
3--- a/contrib/canonical-rules.yaml
4+++ b/contrib/canonical-rules.yaml
5@@ -73,9 +73,10 @@ subordinates:
6 canonical-livepatch:
7 where: host only
8 nrpe:
9- where: container aware # and except nagios
10+ where: container aware
11 host-suffixes: [host, physical, guest]
12 container-suffixes: [lxd, container]
13+ exceptions: [nagios]
14 ntp:
15 where: host only # You don't want NTP in a container duelling with ntp in the host
16 thruk-agent:
17@@ -99,6 +100,7 @@ operations openstack mandatory: &operations-openstack-mandatory-charms
18 - prometheus-libvirt-exporter
19 - prometheus-openstack-exporter
20 - prometheus-ceph-exporter
21+ - prometheus-grok-exporter
22
23 operations mandatory dependencies: &operations-mandatory-deps
24 - postgresql
25@@ -119,6 +121,8 @@ operations optional subordinates: &operations-optional-subs
26 - bcache-tuning
27 - sysconfig
28 - logrotate-charm
29+ - advanced-routing
30+ - rsyslog-forwarder-ha
31
32 operations charms: &operations-charms
33 - *operations-mandatory-charms
34@@ -176,17 +180,30 @@ openstack optional charms: &openstack-optional-charms
35 - swift-proxy
36 - swift-storage
37 - vault
38+ - cinder-lvm
39
40 cisco-aci-charms: &cisco-aci-charms
41 - neutron-api-plugin-aci
42 - openstack-dashboard-plugin-gbp
43
44+ovn-charms: &ovn-charms
45+ - ovn-central
46+ - ovn-chassis
47+ - neutron-api-plugin-ovn
48+
49+masakari-charms: &masakari-charms
50+ - masakari
51+ - masakari-monitors
52+ - pacemaker-remote
53+
54 openstack charms: &openstack-charms
55 - *openstack-mandatory-charms
56 - *openstack-mandatory-deps
57 - *openstack-mandatory-subs
58 - *openstack-optional-charms
59 - *cisco-aci-charms
60+ - *ovn-charms
61+ - *masakari-charms
62
63 known charms:
64 - ubuntu

Subscribers

People subscribed via source and target branches