Grafana Charm

Code review comment for ~afreiberger/charm-grafana:add_tests_and_linting

  1. Git
  2. lp:~afreiberger/charm-grafana
  3. add_tests_and_linting
  4. Merge into master
Revision history for this message
Alvaro Uria (aluria) wrote :

I have worked on adding tests starting from this branch. Since most of the code was a port from template-python-pytest, I have removed the unit tests (no real testing being done) and updated the functional tests following my work at [1].

I will go ahead and reject this change, and will propose a new fix soon.

1. https://bugs.launchpad.net/charm-grafana/+bug/1822329

review: Disapprove

« Back to merge proposal