Code review comment for lp:~afrantzis/unity-system-compositor/voice-call-proximity-over-0.1

> retested with https://code.launchpad.net/~afrantzis/unity8/power-state-change-
> reason-snap-decision
> it matched what i expected, I hammered on this pretty good.

Thanks for testing!

> I found only 2 cosmetic issues, and 1 issue that should likely be addressed
> (unless it's already a bug)

> cosmetic issue 1: if a text or call occurs, screen is lit, no interaction it
> will dim. getting a call or text at that moment will not brighten the screen.

From a quick look at the related USC code, this should be easily fixable (Famous last words? Let's see... :) )

> cosmetic issue 2: incoming call, cover and uncover proximity sensor
> quickly/rapidly and every now and then you will hear the audio stutter only
> very slightly

Covering/uncovering the proximity sensor is an intensive task that involves cross process communication and the teardown and setup of our input and graphics subsystems in USC/Mir. I can't really see anything simple (i.e. as a bugfix) we can do to improve this on the USC side.

> issue to fix: if you are on an active call and hit power button to blank
> screen, generate a second incoming call - as a user you have no idea this has
> occured, there is no vibra nor does the screen light. At least with a text the
> vibra will activate, but no lighting screen. The screen should probably light
> up in both these instances.

This is indeed a regression. With the new code, when a call arrives, USC enables proximity handling and expects a proximity event with the initial proximity state. This is done in order to avoid turning on the screen for a moment if the proximity is "near". However, if proximity handling is already enabled (in this case because the dialer-app has enabled it) USC won't receive a proximity event with the initial state and won't turn on the screen. I am confident there is a way to improve this within our current architecture, but it will probably involve more communication between powerd and USC and more state keeping. I will experiment with a few approaches.

Note that when a second call arrives the users get a beeping noise in the call audio output, so they do get some notification.

Stay tuned!