Code review comment for lp:~afrantzis/unity-system-compositor/fix-1491566-deadlock
Revision history for this message
| Andreas Pokorny (andreas-pokorny) wrote | # |
review:
Needs Information
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
Do you really need the before_* methods in MirScreen?
You could simply override the method and call a before function<> inside the test setup.
Why does that fix the issue? The lock ordering is still the same now?