Code review comment for lp:~afrantzis/mir/variable-length-serialization-buffers-1320187

> > You could avoid this (and some related code in the test body) by:
> > using LargeMessages = mir_test_framework::BasicClientServerFixture<LargeMess
> agesServerConfiguration>;
>
> Without the fix, the client hangs indefinitely in mir_connect, so I need to
> make the connect call async to be able to make the test fail after a
> reasonable amount of time.

I see. I guess this is too "clever"...

template<>
void BasicClientServerFixture<LargeMessagesServerConfiguration>::SetUp()
{
    InProcessServer::SetUp();
    // async connect with timeout
}

...OTOH maybe changing BasicClientServerFixture to timeout & fail instead of hang is a good idea for the general case.

Anyway I'm still approving as is. ;)