Code review comment for lp:~afrantzis/mir/variable-length-serialization-buffers-1320187
Revision history for this message
| Alexandros Frantzis (afrantzis) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
1b1ed1a
(Get the code!)
> It is safe to call delete[] with nullptr (and doing so avoids the test here as well as in the library)
Fixed.
> You could avoid this (and some related code in the test body) by:
> using LargeMessages = mir_test_
Without the fix, the client hangs indefinitely in mir_connect, so I need to make the connect call async to be able to make the test fail after a reasonable amount of time.