Mir

Code review comment for lp:~afrantzis/mir/texture-bindable-over-native-buffer-base

Revision history for this message
Kevin DuBois (kdub) wrote :

> > 224 +class TextureBindable
> > seems like its just a Texture
>
> I don't know... Texture::gl_bind_to_texture() sounds incorrect since if we are
> a texture why do we need to bind to one?
>
> Texture::bind_to_gl_texture() sounds a bit better, since it implies that there
> is a generic Texture entity (the object) and a separate but related entity "gl
> texture" that the Texture object can be bound to.
>
> Another alternative TextureSource::(gl_)bind_to_(gl_)texture()

I like TextureSource (or TextureContent) better than TextureBindable. (pre-approve)

review: Approve

« Back to merge proposal