Mir

Code review comment for lp:~afrantzis/mir/texture-bindable-over-native-buffer-base

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

> You could argue that placing the header in, e.g.,
> include/renderers/mir/renderer/gl/ is more consistent with the current project
> structure, and I agree, but that's also what I want to avoid in order to
> stress the independence of the renderers and their renderer-specific public
> headers from the rest of the project.

I so argue.

> [1] For example see src/platforms/mesa/include/... which contains platform
> specific client headers shipped in mir-client-platform-mesa-dev

I don't like that either. Burying "public" header files under ./src is confusing.

Abstaining because there's a precedent for this approach.

review: Abstain

« Back to merge proposal