Mir

Code review comment for lp:~afrantzis/mir/report-egl-errors-in-exceptions

Revision history for this message
Alexandros Frantzis (afrantzis) wrote :

@Kevin
> could the code in src/platforms/android/server/gl_context.cpp use this too?

12 +++ src/platforms/android/server/gl_context.cpp 2015-04-17 07:34:44 +0000

:)

@Andreas
> I think it would be better to expose egl_error and its typeinfo since it gets thrown around?

mg::egl_error is a convenience class. For all intents the purpose, the exception we are throwing is a std::system_error with an egl_category.

@Alan
> I'm not sure why this code is inline (which requires egl_category() to be published)

See above, and also, in some cases this convenience class may not be usable, since it calls eglGetError() itself.

« Back to merge proposal