Mir

Code review comment for lp:~afrantzis/mir/fix-android-desktop-build-lp-1276621

Revision history for this message
Kevin DuBois (kdub) wrote :

> 68 - memcpy(this, &layer, sizeof(HWCLayer));
> 69 + memcpy(static_cast<void*>(this),
> 70 + static_cast<void const*>(&layer),
> 71 + sizeof(HWCLayer));
>
> NOt sure the casts add anything other than text

Either way, this bit of code (copy/assign for this type) is hopefully going away soon.

Otherwise looks okay to me, thanks for the clean up!

review: Approve

« Back to merge proposal