Mir

Code review comment for lp:~afrantzis/mir/fix-1517781-double-close

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

Makes sense.

But I can still reproduce problems in e.g. NestedServer.display_configuration_reset_when_application_exits

Vis:

Repeating all tests (iteration 429) . . .

Note: Google Test filter = NestedServer.display_configuration_reset_when_application_exits
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from NestedServer
[ RUN ] NestedServer.display_configuration_reset_when_application_exits
/home/alan/display_server/mir3/tests/acceptance-tests/test_nested_mir.cpp:755: Failure
Value of: condition.woken()
  Actual: false
Expected: true
Segmentation fault (core dumped)

So which NestedServer test failures are covered by the linked bug?

review: Approve

« Back to merge proposal