Merge lp:~afrantzis/mir/fix-1445418-release-surfaces into lp:mir

[Alexandros Frantzis]

tests: Properly release MirSurfaces

tests: Properly release MirSurfaces

[Alan Griffiths (alan-griffiths)]

OK as a workaround but slightly changes the test. It would be more consistent to close the surfaces at the end of the test (and not in the test loop). Vis:

        received.wait_for(400ms);
    }

    for (auto const surface : client_surface)
        mir_surface_release_sync(surface);
}

review: Approve

[Alexandros Frantzis (afrantzis)]

> It would be more consistent to close the surfaces at the end of the test (and not in the test loop)

Changed.

[Alan Griffiths (alan-griffiths)]

Even more OK (but shouldn't be needed).

Unfortunately lp:1445473 isn't as tractable as I first hoped.

review: Approve

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:2496
http://jenkins.qa.ubuntu.com/job/mir-ci/3561/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-vivid-i386-build/2105
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-vivid-amd64-build/2104
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-vivid-touch/2055
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-vivid-amd64-ci/1558
        deb: http://jenkins.qa.ubuntu.com/job/mir-vivid-amd64-ci/1558/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/2055
        deb: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/2055/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-runner-mako/4987
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/19755

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-ci/3561/rebuild

review: Approve (continuous-integration)

=== modified file 'tests/acceptance-tests/test_custom_window_management.cpp'
--- tests/acceptance-tests/test_custom_window_management.cpp	2015-04-15 15:40:55 +0000
+++ tests/acceptance-tests/test_custom_window_management.cpp	2015-04-17 13:55:18 +0000
@@ -268,4 +268,7 @@
 
         received.wait_for(400ms);
     }
+
+    for (auto const surface : client_surface)
+        mir_surface_release_sync(surface);
 }