Mir

Merge lp:~afrantzis/mir/fix-1362646-gmock-build-dep into lp:mir

Proposed by Alexandros Frantzis
Status: Merged
Approved by: Daniel van Vugt
Approved revision: no longer in the source branch.
Merged at revision: 1873
Proposed branch: lp:~afrantzis/mir/fix-1362646-gmock-build-dep
Merge into: lp:mir
Diff against target: 80 lines (+15/-0)
6 files modified
tests/acceptance-tests/CMakeLists.txt (+3/-0)
tests/integration-tests/CMakeLists.txt (+2/-0)
tests/mir_test_doubles/CMakeLists.txt (+3/-0)
tests/mir_test_framework/CMakeLists.txt (+3/-0)
tests/performance-tests/CMakeLists.txt (+2/-0)
tests/unit-tests/CMakeLists.txt (+2/-0)
To merge this branch: bzr merge lp:~afrantzis/mir/fix-1362646-gmock-build-dep
Reviewer Review Type Date Requested Status
Daniel van Vugt Approve
Kevin DuBois (community) Approve
Alan Griffiths Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+232582@code.launchpad.net

Commit message

tests: Explicitly depend on GMock target to avoid build races (LP: #1362646)

Description of the change

tests: Explicitly depend on GMock target to avoid build races

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

LGTM

review: Approve
Revision history for this message
Kevin DuBois (kdub) :
review: Approve
Revision history for this message
Daniel van Vugt (vanvugt) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'tests/acceptance-tests/CMakeLists.txt'
--- tests/acceptance-tests/CMakeLists.txt 2014-08-06 15:15:35 +0000
+++ tests/acceptance-tests/CMakeLists.txt 2014-08-28 14:39:17 +0000
@@ -59,6 +59,9 @@
5959
60 ${SOURCES}60 ${SOURCES}
61)61)
62
63add_dependencies(mir_acceptance_tests GMock)
64
62uses_android_input(mir_acceptance_tests)65uses_android_input(mir_acceptance_tests)
6366
6467
6568
=== modified file 'tests/integration-tests/CMakeLists.txt'
--- tests/integration-tests/CMakeLists.txt 2014-08-26 09:27:49 +0000
+++ tests/integration-tests/CMakeLists.txt 2014-08-28 14:39:17 +0000
@@ -50,6 +50,8 @@
50 ${MIR_COMMON_OBJECTS}50 ${MIR_COMMON_OBJECTS}
51)51)
5252
53add_dependencies(mir_integration_tests GMock)
54
53uses_android_input(mir_integration_tests)55uses_android_input(mir_integration_tests)
5456
55target_link_libraries(57target_link_libraries(
5658
=== modified file 'tests/mir_test_doubles/CMakeLists.txt'
--- tests/mir_test_doubles/CMakeLists.txt 2014-08-15 15:04:40 +0000
+++ tests/mir_test_doubles/CMakeLists.txt 2014-08-28 14:39:17 +0000
@@ -38,6 +38,9 @@
38add_library(38add_library(
39 mir-test-doubles STATIC39 mir-test-doubles STATIC
40 ${TEST_UTILS_SRCS})40 ${TEST_UTILS_SRCS})
41
42add_dependencies(mir-test-doubles GMock)
43
41uses_android_input(mir-test-doubles)44uses_android_input(mir-test-doubles)
4245
43target_link_libraries(46target_link_libraries(
4447
=== modified file 'tests/mir_test_framework/CMakeLists.txt'
--- tests/mir_test_framework/CMakeLists.txt 2014-08-15 15:04:40 +0000
+++ tests/mir_test_framework/CMakeLists.txt 2014-08-28 14:39:17 +0000
@@ -36,6 +36,9 @@
36 mir-test-framework STATIC36 mir-test-framework STATIC
37 ${TEST_FRAMEWORK_SRCS}37 ${TEST_FRAMEWORK_SRCS}
38)38)
39
40add_dependencies(mir-test-framework GMock)
41
39uses_android_input(mir-test-framework)42uses_android_input(mir-test-framework)
4043
41target_link_libraries(44target_link_libraries(
4245
=== modified file 'tests/performance-tests/CMakeLists.txt'
--- tests/performance-tests/CMakeLists.txt 2014-08-15 15:04:40 +0000
+++ tests/performance-tests/CMakeLists.txt 2014-08-28 14:39:17 +0000
@@ -10,6 +10,8 @@
10 ${PERFORMANCE_TESTS_SOURCES}10 ${PERFORMANCE_TESTS_SOURCES}
11)11)
1212
13add_dependencies(mir_performance_tests GMock)
14
13target_link_libraries(15target_link_libraries(
14 mir_performance_tests16 mir_performance_tests
1517
1618
=== modified file 'tests/unit-tests/CMakeLists.txt'
--- tests/unit-tests/CMakeLists.txt 2014-08-26 09:27:49 +0000
+++ tests/unit-tests/CMakeLists.txt 2014-08-28 14:39:17 +0000
@@ -47,6 +47,8 @@
47 ${MIR_COMMON_OBJECTS}47 ${MIR_COMMON_OBJECTS}
48)48)
4949
50add_dependencies(mir_unit_tests GMock)
51
50uses_android_input(mir_unit_tests)52uses_android_input(mir_unit_tests)
5153
52target_link_libraries(54target_link_libraries(

Subscribers

People subscribed via source and target branches