Mir

Merge lp:~afrantzis/mir/fix-1286010 into lp:mir

Proposed by Alexandros Frantzis
Status: Merged
Approved by: Alan Griffiths
Approved revision: no longer in the source branch.
Merged at revision: 1459
Proposed branch: lp:~afrantzis/mir/fix-1286010
Merge into: lp:mir
Diff against target: 69 lines (+5/-3)
5 files modified
examples/image_renderer.cpp (+1/-0)
examples/render_surfaces.cpp (+0/-2)
include/test/mir_test_doubles/fake_renderable.h (+1/-0)
src/server/compositor/gl_renderer.cpp (+1/-0)
src/server/scene/basic_surface.cpp (+2/-1)
To merge this branch: bzr merge lp:~afrantzis/mir/fix-1286010
Reviewer Review Type Date Requested Status
Alan Griffiths Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+210185@code.launchpad.net

Commit message

Fix glm build warnings

Description of the change

Fix glm build warnings

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'examples/image_renderer.cpp'
--- examples/image_renderer.cpp 2014-03-04 04:09:36 +0000
+++ examples/image_renderer.cpp 2014-03-10 11:11:24 +0000
@@ -23,6 +23,7 @@
23#pragma GCC diagnostic warning "-Wall"23#pragma GCC diagnostic warning "-Wall"
24#include <glm/glm.hpp>24#include <glm/glm.hpp>
25#pragma GCC diagnostic pop25#pragma GCC diagnostic pop
26#define GLM_FORCE_RADIANS
26#include <glm/gtc/type_ptr.hpp>27#include <glm/gtc/type_ptr.hpp>
2728
28#include <memory>29#include <memory>
2930
=== modified file 'examples/render_surfaces.cpp'
--- examples/render_surfaces.cpp 2014-03-06 19:05:47 +0000
+++ examples/render_surfaces.cpp 2014-03-10 11:11:24 +0000
@@ -49,8 +49,6 @@
49#include <sstream>49#include <sstream>
50#include <vector>50#include <vector>
5151
52#include <glm/gtc/matrix_transform.hpp>
53
54namespace mg = mir::graphics;52namespace mg = mir::graphics;
55namespace mc = mir::compositor;53namespace mc = mir::compositor;
56namespace ms = mir::scene;54namespace ms = mir::scene;
5755
=== modified file 'include/test/mir_test_doubles/fake_renderable.h'
--- include/test/mir_test_doubles/fake_renderable.h 2014-03-06 05:29:00 +0000
+++ include/test/mir_test_doubles/fake_renderable.h 2014-03-10 11:11:24 +0000
@@ -20,6 +20,7 @@
20#define MIR_TEST_DOUBLES_FAKE_RENDERABLE_H_20#define MIR_TEST_DOUBLES_FAKE_RENDERABLE_H_
2121
22#include "mir/graphics/renderable.h"22#include "mir/graphics/renderable.h"
23#define GLM_FORCE_RADIANS
23#include <glm/gtc/matrix_transform.hpp>24#include <glm/gtc/matrix_transform.hpp>
24#include <gmock/gmock.h>25#include <gmock/gmock.h>
2526
2627
=== modified file 'src/server/compositor/gl_renderer.cpp'
--- src/server/compositor/gl_renderer.cpp 2014-03-04 04:09:36 +0000
+++ src/server/compositor/gl_renderer.cpp 2014-03-10 11:11:24 +0000
@@ -20,6 +20,7 @@
20#include "mir/graphics/renderable.h"20#include "mir/graphics/renderable.h"
21#include "mir/graphics/buffer.h"21#include "mir/graphics/buffer.h"
2222
23#define GLM_FORCE_RADIANS
23#include <glm/gtc/matrix_transform.hpp>24#include <glm/gtc/matrix_transform.hpp>
24#include <glm/gtc/type_ptr.hpp>25#include <glm/gtc/type_ptr.hpp>
2526
2627
=== modified file 'src/server/scene/basic_surface.cpp'
--- src/server/scene/basic_surface.cpp 2014-03-06 19:05:47 +0000
+++ src/server/scene/basic_surface.cpp 2014-03-10 11:11:24 +0000
@@ -25,6 +25,7 @@
2525
26#include "mir/scene/scene_report.h"26#include "mir/scene/scene_report.h"
2727
28#define GLM_FORCE_RADIANS
28#include <glm/gtc/matrix_transform.hpp>29#include <glm/gtc/matrix_transform.hpp>
2930
30#include <boost/throw_exception.hpp>31#include <boost/throw_exception.hpp>
@@ -241,7 +242,7 @@
241{242{
242 {243 {
243 std::unique_lock<std::mutex> lk(guard);244 std::unique_lock<std::mutex> lk(guard);
244 rotation_matrix = glm::rotate(glm::mat4(1.0f), degrees, axis);245 rotation_matrix = glm::rotate(glm::mat4(1.0f), glm::radians(degrees), axis);
245 transformation_dirty = true;246 transformation_dirty = true;
246 }247 }
247 notify_change();248 notify_change();

Subscribers

People subscribed via source and target branches