Mir

Code review comment for lp:~afrantzis/mir/drm-device-fd-close-on-exec

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

This looks like a potential mismatch:

3 parameters mocked:
8 + MOCK_METHOD3(open, int(char const* path, int flags, mode_t mode));

2 parameters used:
35 + tmp_fd = open(device.devnode(), O_RDWR | O_CLOEXEC);

Maybe it mocks correctly still? I guess the expectations would fail otherwise. The real function is:
/usr/include/fcntl.h:extern int open (const char *__file, int __oflag, ...) __nonnull ((1));

Seems to work.

review: Approve

« Back to merge proposal