Mir

Code review comment for lp:~afrantzis/mir/different-mesa-display-validation-functions

  1. different-mesa-display-validation-functions
  2. Merge into trunk
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Can we find a way to make the new function names less wordy and more consistent?...

mir_server_egl_mesa_display_is_valid(MirMesaEGLNativeDisplay* display)
mir_client_egl_mesa_display_is_valid(MirMesaEGLNativeDisplay* display)

By wordy, I mean they're almost too long. By consistent I mean the words are in a different order in the function name to the parameter: egl_mesa vs MesaEGL

Another inconsistency is use of the word "client". No other client functions do that. So maybe drop "_client_". But admittedly that would be inconsistent too.

review: Needs Information

« Back to merge proposal