Merge lp:~afrantzis/mir/automate-package-abi-versioning into lp:mir

[Alexandros Frantzis]

debian: Automate creation of packaging files based on the current component ABIs

debian: Automate creation of packaging files based on the current component ABIs

With this MP some packaging files (debian/control and various debian/*.install files) are produced at package build time based on the ABIs detected in the source tree (but see "Future improvements" below).

Because during package pre-creation dpkg-source needs preliminary access to the source package fields (i.e. the top fields) of the control file, debian/control is symlinked to debian/control.in. At the beginning of the build process, the symlink is overwritten with a proper control file produced from control.in.

Using a control file produced at build time is a neat and versatile idea. However, there may be issues (e.g. too fragile?) we are not aware of and it may not be acceptable to our debian packaging overlords. If that's the case then we can fall back to having a script that can be invoked manually to update our packaging, plus corresponding tests to ensure that our packaging and source tree (i.e. ABIs) are in sync.

Future improvements:

* Improve how we handle ABIs in the source tree, so that we can detect them more cleanly at package build time (i.e. not grep through all the sources). Perhaps a single file that both CMake and our packaging scripts could read?

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:2353
http://jenkins.qa.ubuntu.com/job/mir-ci/3102/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-vivid-i386-build/1468
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-vivid-amd64-build/1467
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-vivid-touch/1422
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-vivid-amd64-ci/1099
        deb: http://jenkins.qa.ubuntu.com/job/mir-vivid-amd64-ci/1099/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/1422
        deb: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/1422/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-runner-mako/4443
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/18468

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-ci/3102/rebuild

review: Approve (continuous-integration)

[Cemil Azizoglu (cemil-azizoglu)]

Thanks for the quick action and this MP. Since CI is not good at detecting packaging issues, could you mention the testing you've done on this MP?

review: Needs Information

[Alexandros Frantzis (afrantzis)]

> Thanks for the quick action and this MP. Since CI is not good at detecting packaging issues,
> could you mention the testing you've done on this MP?

Since the MP changes the packaging process but not the packaging output, I focused on ensuring the new packages matched packages created from trunk. I checked this by locally creating both sets of packages and comparing.

There is also the confidence we get from the successful CI run. Although CI doesn't detect all packaging issues, it can detect a decent amount of them, especially since we enabled installation of all packages in mediumtests last week.

[Kevin DuBois (kdub)]

lgtm

review: Approve

[Alan Griffiths (alan-griffiths)]

I like the autogeneration but I worry about it being fragile in ways I do not understand.

Also isn't there a risk of accidentally checking in the generated file that overwrites the link?

review: Abstain

[Cemil Azizoglu (cemil-azizoglu)]

I don't think it's good to have a symlink for debian/control. If the script fails then everything should fail in a spectacular manner, and not act like it has a way to proceed.

review: Needs Fixing

[Robert Carr (robertcarr)]

>>I don't think it's good to have a symlink for debian/control. If the script fails then everything
>> should fail in a spectacular manner, and not act like it has a way to proceed.

It sounds like the symlink is required because dpkg-buildpackage wants to parse a few non ABI (hopefully!) fields from debian/control prior to kicking off the full build (and performing the autogeneration).

LGTM

review: Approve

[Chris Halse Rogers (raof)]

I expect this would be NAKed by the distro team.

The ‘traditional’ way this is done is in the clean: (so, override_dh_clean) target; this ensures that it's run before generating the source package. Currently When debian/control autogeneration is done at all it's done to populate a relatively contained field, such as Uploaders:.

Although it's autogenerated we should still have debian/control in source control.

As a distro packager I would not do this, but the “upstreams contain packaging and automatically land in the distro” world is still strange and it seems like this might be reasonable for us to do.

Maybe this is better off as something in tools/ to manually run when necessary?

review: Abstain

[Alexandros Frantzis (afrantzis)]

> I expect this would be NAKed by the distro team.
>
> Maybe this is better off as something in tools/ to manually run when necessary?

This matches the fallback I mentioned in the description: "If that's the case then we can fall back to having a script that can be invoked manually to update our packaging, plus corresponding tests to ensure that our packaging and source tree (i.e. ABIs) are in sync."

Let's see what distro says.

[Colin Watson (cjwatson)]

I agree with Chris's comments above. Autogenerating debian/control like this is dangerous and tends to play hell with tools that expect the list of package names to be accurate at the point when the source package is built; as written this will probably result in an incorrect .dsc file in some cases, causing archive problems. Best practice when this stuff is necessary is to do it in the clean rule so that the source package is accurate, or to have a script to update it manually when necessary.

review: Needs Fixing

[Adam Conrad (adconrad)]

02:38 < infinity> alf: I would NACK it if you asked for a review from me. :P
02:39 < infinity> alf: debian/control should be correct, leading to .dsc actually listing the binary packages a source produces. Your control and .dsc contain garbage until build time, which is unacceptably wrong.
02:39 < infinity> alf: Generating that at source package creation time is fine, though. You should just do that.

As an added bonus, using the symlink trick here, your debian/control isn't just inaccurate, but actually syntactically broken, as it contains invalid characters in the Package: fields.

review: Needs Fixing

[Adam Conrad (adconrad)]

Another aside, if you ever intend to get this stuff into Debian, the Debian ftp/build infrastructure is very picky about sources producing the binaries listed in .dsc (I had to fix glibc to stop listing some binaries it didn't produce), so this really should just be done correctly from the get go.

[Alexandros Frantzis (afrantzis)]

OK, it seems that, as feared, automagic creation of debian/control is indeed fragile and needs special care. Although there are ways to make it work, the process will become more complicated than what I would like. It's much more straightforward to go for a scripted but manual packaging update and tests to check for inconsistencies between source tree ABIs and packaging. Stay tuned for a new MP.

review: Disapprove

Unmerged revisions

2353. By Alexandros Frantzis on 2015-03-02

debian: Automate creation of packaging files based on the current component ABIs

=== added symlink 'debian/control'
=== target is u'control.in'
=== renamed file 'debian/control' => 'debian/control.in'
--- debian/control	2015-02-27 15:54:19 +0000
+++ debian/control.in	2015-03-02 13:06:12 +0000
@@ -45,7 +45,7 @@
 # just go ahead. ~mir-team will notice and sync up the code again.
 Vcs-Bzr: https://code.launchpad.net/~mir-team/mir/trunk
 
-Package: libmirprotobuf0
+Package: libmirprotobuf@MIRPROTOBUF_ABI@
 Section: libs
 Architecture: i386 amd64 armhf arm64
 Multi-Arch: same
@@ -61,7 +61,7 @@
 
 #TODO: Packaging infrastructure for better dependency generation,
 #      ala pkg-xorg's xviddriver:Provides and ABI detection.
-Package: libmirserver31
+Package: libmirserver@MIRSERVER_ABI@
 Section: libs
 Architecture: i386 amd64 armhf arm64
 Multi-Arch: same
@@ -74,7 +74,7 @@
  .
  Contains the shared library needed by server applications for Mir.
 
-Package: libmirplatform7
+Package: libmirplatform@MIRPLATFORM_ABI@
 Section: libs
 Architecture: i386 amd64 armhf arm64
 Multi-Arch: same
@@ -93,7 +93,7 @@
 Architecture: i386 amd64 armhf arm64
 Multi-Arch: same
 Pre-Depends: ${misc:Pre-Depends}
-Depends: libmircommon3 (= ${binary:Version}), 
+Depends: libmircommon@MIRCOMMON_ABI@ (= ${binary:Version}),
          libprotobuf-dev (>= 2.4.1),
          libxkbcommon-dev,
          ${misc:Depends},
@@ -110,7 +110,7 @@
 Architecture: i386 amd64 armhf arm64
 Multi-Arch: same
 Pre-Depends: ${misc:Pre-Depends}
-Depends: libmirplatform7 (= ${binary:Version}),
+Depends: libmirplatform@MIRPLATFORM_ABI@ (= ${binary:Version}),
          libmircommon-dev,
          libboost-program-options-dev,
          ${misc:Depends},
@@ -127,7 +127,7 @@
 Architecture: i386 amd64 armhf arm64
 Multi-Arch: same
 Pre-Depends: ${misc:Pre-Depends}
-Depends: libmirserver31 (= ${binary:Version}),
+Depends: libmirserver@MIRSERVER_ABI@ (= ${binary:Version}),
          libmirplatform-dev (= ${binary:Version}),
          libmircommon-dev (= ${binary:Version}),
          libglm-dev,
@@ -138,7 +138,7 @@
  .
  Contains header files required to build Mir servers.
 
-Package: libmirclient8
+Package: libmirclient@MIRCLIENT_ABI@
 Section: libs
 Architecture: i386 amd64 armhf arm64
 Multi-Arch: same
@@ -156,7 +156,7 @@
 Architecture: i386 amd64 armhf arm64
 Multi-Arch: same
 Pre-Depends: ${misc:Pre-Depends}
-Depends: libmirclient8 (= ${binary:Version}),
+Depends: libmirclient@MIRCLIENT_ABI@ (= ${binary:Version}),
          libmircommon-dev (= ${binary:Version}),
          libprotobuf-dev (>= 2.4.1),
          ${misc:Depends},
@@ -166,7 +166,7 @@
  .
  Contains header files required to develop against Mir.
 
-Package: libmirclient-debug-extension1
+Package: libmirclient-debug-extension@MIRCLIENT_DEBUG_EXTENSION_ABI@
 Section: libs
 Architecture: i386 amd64 armhf arm64
 Multi-Arch: same
@@ -192,8 +192,8 @@
 Architecture: i386 amd64 armhf arm64
 Multi-Arch: same
 Pre-Depends: ${misc:Pre-Depends}
-Depends: libmirclient-debug-extension1 (= ${binary:Version}),
-	 ${misc:Depends},
+Depends: libmirclient-debug-extension@MIRCLIENT_DEBUG_EXTENSION_ABI@ (= ${binary:Version}),
+         ${misc:Depends},
          ${shlibs:Depends},
 Description: Display server for Ubuntu - client debug interface headers
  Mir is a display server running on linux systems, with a focus on efficiency,
@@ -252,7 +252,7 @@
  .
  Contains a tool for stress testing the Mir display server
 
-Package: libmircommon3
+Package: libmircommon@MIRCOMMON_ABI@
 Section: libs
 Architecture: i386 amd64 armhf arm64
 Multi-Arch: same
@@ -266,7 +266,7 @@
  Contains the shared libraries required for the Mir server and client.
 
 # Longer-term these drivers should move out-of-tree
-Package: mir-platform-graphics-mesa2
+Package: mir-platform-graphics-mesa@MIR_SERVER_GRAPHICS_PLATFORM_ABI@
 Section: libs
 Architecture: i386 amd64 armhf arm64
 Multi-Arch: same
@@ -280,7 +280,7 @@
  Contains the shared libraries required for the Mir server to interact with
  the hardware platform using the Mesa drivers.
 
-Package: mir-platform-graphics-android2
+Package: mir-platform-graphics-android@MIR_SERVER_GRAPHICS_PLATFORM_ABI@
 Section: libs
 Architecture: i386 amd64 armhf
 Multi-Arch: same
@@ -294,7 +294,7 @@
  Contains the shared libraries required for the Mir server to interact with
  the hardware platform using the Android drivers.
 
-Package: mir-client-platform-mesa2
+Package: mir-client-platform-mesa@MIR_CLIENT_PLATFORM_ABI@
 Section: libs
 Architecture: i386 amd64 armhf arm64
 Multi-Arch: same
@@ -322,7 +322,7 @@
  Contains header files required to use the platform specific capabilities of
  the Mir Mesa backend.
 
-Package: mir-client-platform-android2
+Package: mir-client-platform-android@MIR_CLIENT_PLATFORM_ABI@
 Section: libs
 Architecture: i386 amd64 armhf
 Multi-Arch: same
@@ -342,8 +342,8 @@
 Multi-Arch: same
 Pre-Depends: ${misc:Pre-Depends}
 Depends: ${misc:Depends},
-         mir-platform-graphics-mesa2,
-         mir-client-platform-mesa2,
+         mir-platform-graphics-mesa@MIR_SERVER_GRAPHICS_PLATFORM_ABI@,
+         mir-client-platform-mesa@MIR_CLIENT_PLATFORM_ABI@,
 Description: Display server for Ubuntu - desktop driver metapackage
  Mir is a display server running on linux systems, with a focus on efficiency,
  robust operation and a well-defined driver model.
@@ -357,8 +357,8 @@
 Multi-Arch: same
 Pre-Depends: ${misc:Pre-Depends}
 Depends: ${misc:Depends},
-         mir-platform-graphics-android2,
-         mir-client-platform-android2,
+         mir-platform-graphics-android@MIR_SERVER_GRAPHICS_PLATFORM_ABI@,
+         mir-client-platform-android@MIR_CLIENT_PLATFORM_ABI@,
 Description: Display server for Ubuntu - android driver metapackage
  Mir is a display server running on linux systems, with a focus on efficiency,
  robust operation and a well-defined driver model.
 
=== added file 'debian/create_control_and_install_files.sh'
--- debian/create_control_and_install_files.sh	1970-01-01 00:00:00 +0000
+++ debian/create_control_and_install_files.sh	2015-03-02 13:06:12 +0000
@@ -0,0 +1,78 @@
+#!/bin/sh
+
+set -e
+
+abi_vars="\
+    MIRCLIENT_ABI \
+    MIRCLIENT_DEBUG_EXTENSION_ABI \
+    MIR_CLIENT_PLATFORM_ABI \
+    MIRCOMMON_ABI \
+    MIRPLATFORM_ABI \
+    MIRPROTOBUF_ABI \
+    MIRSERVER_ABI \
+    MIR_SERVER_GRAPHICS_PLATFORM_ABI"
+
+install_files="\
+    libmirclient:MIRCLIENT_ABI \
+    libmirclient-debug-extension:MIRCLIENT_DEBUG_EXTENSION_ABI \
+    libmircommon:MIRCOMMON_ABI \
+    libmirplatform:MIRPLATFORM_ABI \
+    libmirprotobuf:MIRPROTOBUF_ABI \
+    libmirserver:MIRSERVER_ABI \
+    mir-client-platform-android:MIR_CLIENT_PLATFORM_ABI \
+    mir-client-platform-mesa:MIR_CLIENT_PLATFORM_ABI \
+    mir-platform-graphics-android:MIR_SERVER_GRAPHICS_PLATFORM_ABI \
+    mir-platform-graphics-mesa:MIR_SERVER_GRAPHICS_PLATFORM_ABI"
+
+
+get_abi_number()
+{
+    local abi_var=$1
+    grep -R "set($abi_var" src/* | grep -o '[[:digit:]]\+'
+}
+
+populate_abi_variables()
+{
+    for abi_var in $abi_vars;
+    do
+        local tmp=$(get_abi_number $abi_var)
+        if [ -z "$tmp" ];
+        then
+            echo "Failed to find ABI number for $abi_var"
+            exit 1
+        fi
+        eval "$abi_var=$tmp"
+    done
+}
+
+create_control_file()
+{
+    local cmd="sed"
+
+    for abi_var in $abi_vars;
+    do
+        cmd="$cmd -e \"s/@$abi_var@/\${$abi_var}/\""
+    done
+
+    cmd="$cmd debian/control.in > debian/control"
+
+    # Remove the debian/control symlink before writing to it
+    rm debian/control
+    eval "$cmd"
+}
+
+create_install_files()
+{
+    for f in $install_files;
+    do
+        local pkg=${f%%:*}
+        local abi_var=${f##*:}
+        local abi=$(eval "echo \$${abi_var}")
+        sed "s/@$abi_var@/$abi/" \
+            debian/${pkg}.install.in > debian/${pkg}${abi}.install
+    done
+}
+
+populate_abi_variables
+create_control_file
+create_install_files
 
=== removed file 'debian/create_postinst_prerm_scripts.sh'
--- debian/create_postinst_prerm_scripts.sh	2015-01-21 07:34:50 +0000
+++ debian/create_postinst_prerm_scripts.sh	1970-01-01 00:00:00 +0000
@@ -1,39 +0,0 @@
-#!/bin/sh
-
-set -e
-
-dpkg_alternatives_priority=500
-deb_host_arch=$1
-deb_host_multiarch=$2
-
-mir_platform_types="${PLATFORM_DRIVER}"
-case $deb_host_arch in
-    arm64)
-        mir_platforms="mesa"
-        ;;
-    *)
-        mir_platforms="android mesa"
-        ;;
-esac
-
-create_script()
-{
-    local script=$1
-    local platform_type=$2
-    local platform=$3
-
-    sed -e "s/@DEB_HOST_MULTIARCH@/$deb_host_multiarch/" \
-        -e "s/@MIR_PLATFORM_TYPE@/$platform_type/" \
-        -e "s/@MIR_PLATFORM@/$platform/" \
-        -e "s/@DPKG_ALTERNATIVES_PRIORITY@/$dpkg_alternatives_priority/" \
-        debian/update-alternatives.${script}.in > debian/libmir$platform_type-$platform.${script}
-}
-
-for platform_type in $mir_platform_types;
-do
-    for platform in $mir_platforms;
-    do
-        create_script postinst $platform_type $platform
-        create_script prerm $platform_type $platform
-    done
-done
 
=== removed file 'debian/install_ld_so_conf.sh'
--- debian/install_ld_so_conf.sh	2015-01-21 07:34:50 +0000
+++ debian/install_ld_so_conf.sh	1970-01-01 00:00:00 +0000
@@ -1,26 +0,0 @@
-#!/bin/sh
-
-set -e
-
-DEB_HOST_ARCH=$1
-DEB_HOST_MULTIARCH=$2
-
-mir_platform_types="${PLATFORM_DRIVER} ${CLIENT_DRIVER}"
-case $DEB_HOST_ARCH in
-    arm64)
-        mir_platforms="mesa"
-        ;;
-    *)
-        mir_platforms="android mesa"
-        ;;
-esac
-
-for platform_type in $mir_platform_types;
-do
-    for platform in $mir_platforms;
-    do
-        platform_dir="/usr/lib/$DEB_HOST_MULTIARCH/mir/$platform_type/$platform"
-        package_dir="debian/libmir$platform_type-$platform/$platform_dir"
-        echo "$platform_dir" > $package_dir/ld.so.conf
-    done
-done
 
=== renamed file 'debian/libmirclient-debug-extension1.install' => 'debian/libmirclient-debug-extension.install.in'
--- debian/libmirclient-debug-extension1.install	2014-08-25 07:23:50 +0000
+++ debian/libmirclient-debug-extension.install.in	2015-03-02 13:06:12 +0000
@@ -1,1 +1,1 @@
-usr/lib/*/libmirclient-debug-extension.so.*
+usr/lib/*/libmirclient-debug-extension.so.@MIRCLIENT_DEBUG_EXTENSION_ABI@
 
=== renamed file 'debian/libmirclient8.install' => 'debian/libmirclient.install.in'
--- debian/libmirclient8.install	2015-01-21 07:34:50 +0000
+++ debian/libmirclient.install.in	2015-03-02 13:06:12 +0000
@@ -1,1 +1,1 @@
-usr/lib/*/libmirclient.so.8
+usr/lib/*/libmirclient.so.@MIRCLIENT_ABI@
 
=== renamed file 'debian/libmircommon3.install' => 'debian/libmircommon.install.in'
--- debian/libmircommon3.install	2015-01-21 07:34:50 +0000
+++ debian/libmircommon.install.in	2015-03-02 13:06:12 +0000
@@ -1,1 +1,1 @@
-usr/lib/*/libmircommon.so.3
+usr/lib/*/libmircommon.so.@MIRCOMMON_ABI@
 
=== renamed file 'debian/libmirplatform7.install' => 'debian/libmirplatform.install.in'
--- debian/libmirplatform7.install	2015-02-14 00:01:13 +0000
+++ debian/libmirplatform.install.in	2015-03-02 13:06:12 +0000
@@ -1,1 +1,1 @@
-usr/lib/*/libmirplatform.so.7
+usr/lib/*/libmirplatform.so.@MIRPLATFORM_ABI@
 
=== renamed file 'debian/libmirprotobuf0.install' => 'debian/libmirprotobuf.install.in'
--- debian/libmirprotobuf0.install	2014-10-21 15:42:39 +0000
+++ debian/libmirprotobuf.install.in	2015-03-02 13:06:12 +0000
@@ -1,1 +1,1 @@
-usr/lib/*/libmirprotobuf.so.0
+usr/lib/*/libmirprotobuf.so.@MIRPROTOBUF_ABI@
 
=== renamed file 'debian/libmirserver31.install' => 'debian/libmirserver.install.in'
--- debian/libmirserver31.install	2015-02-23 16:36:21 +0000
+++ debian/libmirserver.install.in	2015-03-02 13:06:12 +0000
@@ -1,1 +1,1 @@
-usr/lib/*/libmirserver.so.31
+usr/lib/*/libmirserver.so.@MIRSERVER_ABI@
 
=== renamed file 'debian/mir-client-platform-android2.install' => 'debian/mir-client-platform-android.install.in'
--- debian/mir-client-platform-android2.install	2015-02-20 12:11:25 +0000
+++ debian/mir-client-platform-android.install.in	2015-03-02 13:06:12 +0000
@@ -1,1 +1,1 @@
-usr/lib/*/mir/client-platform/android.so.2
+usr/lib/*/mir/client-platform/android.so.@MIR_CLIENT_PLATFORM_ABI@
 
=== renamed file 'debian/mir-client-platform-mesa2.install' => 'debian/mir-client-platform-mesa.install.in'
--- debian/mir-client-platform-mesa2.install	2015-02-20 12:11:25 +0000
+++ debian/mir-client-platform-mesa.install.in	2015-03-02 13:06:12 +0000
@@ -1,1 +1,1 @@
-usr/lib/*/mir/client-platform/mesa.so.2
+usr/lib/*/mir/client-platform/mesa.so.@MIR_CLIENT_PLATFORM_ABI@
 
=== renamed file 'debian/mir-platform-graphics-android2.install' => 'debian/mir-platform-graphics-android.install.in'
--- debian/mir-platform-graphics-android2.install	2015-02-20 12:11:25 +0000
+++ debian/mir-platform-graphics-android.install.in	2015-03-02 13:06:12 +0000
@@ -1,1 +1,1 @@
-usr/lib/*/mir/server-platform/graphics-android.so.2
+usr/lib/*/mir/server-platform/graphics-android.so.@MIR_SERVER_GRAPHICS_PLATFORM_ABI@
 
=== renamed file 'debian/mir-platform-graphics-mesa2.install' => 'debian/mir-platform-graphics-mesa.install.in'
--- debian/mir-platform-graphics-mesa2.install	2015-02-20 12:11:25 +0000
+++ debian/mir-platform-graphics-mesa.install.in	2015-03-02 13:06:12 +0000
@@ -1,1 +1,1 @@
-usr/lib/*/mir/server-platform/graphics-mesa.so.2
+usr/lib/*/mir/server-platform/graphics-mesa.so.@MIR_SERVER_GRAPHICS_PLATFORM_ABI@
 
=== modified file 'debian/rules'
--- debian/rules	2015-02-13 06:12:34 +0000
+++ debian/rules	2015-03-02 13:06:12 +0000
@@ -16,6 +16,10 @@
 %:
 	dh $@ --parallel --fail-missing
 
+override_dh_testdir:
+	sh debian/create_control_and_install_files.sh
+	dh_testdir
+
 #overrding dh_auto_test to get rid of --parallel during testing
 override_dh_auto_test:
 	GTEST_OUTPUT=xml:./ dh_auto_test --max-parallel=1 -- ARGS="-V"
 
=== modified file 'src/protobuf/CMakeLists.txt'
--- src/protobuf/CMakeLists.txt	2015-01-21 07:34:50 +0000
+++ src/protobuf/CMakeLists.txt	2015-03-02 13:06:12 +0000
@@ -25,11 +25,13 @@
   ${PROTOBUF_LIBRARIES}
 )
 
+set(MIRPROTOBUF_ABI 0)
+
 set_target_properties(
   mirprotobuf
 
   PROPERTIES
-  SOVERSION 0
+  SOVERSION ${MIRPROTOBUF_ABI}
 )
 
 # Export the include directories