Mir

Code review comment for lp:~afrantzis/mir/android-fix-memory-error

Revision history for this message
Kevin DuBois (kdub) wrote :

okay, this is a weird problem that points out the problem of using android types. We pull then nativewindow type over hybris using a c-type, which casts away the ability to use the FramebufferNativeWindow's destructors. If we cast back to this type, we have to use FramebufferNativeWindow's private destructor, which isn't possible to pull over hybris.
*sigh*

you're right that we can't manage this object's deletion with our std::shared_ptr... but we also don't have a route to free up the framebuffers. (other than the process dying, where the kernel will free them up)

long story short.... this problem hits 'the perfect storm' of hybris limitations and silly android classes.
I just ported the annoying class over into our 3rd party, hope to mp, kill the strange dependency, and make multithreaded compositor landable for android.

I'm going to disapprove, in favor of porting the type over

review: Disapprove

« Back to merge proposal